Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance CNI config load error condition UX #3716

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Enhance CNI config load error condition UX #3716

merged 1 commit into from
Dec 3, 2024

Conversation

apostasie
Copy link
Contributor

Tentatively fix #3691

Error output should be a bit better:

  • always point out which file is a problem
  • point people to godoc for schema details

@apostasie apostasie marked this pull request as ready for review December 2, 2024 23:49
@AkihiroSuda AkihiroSuda added this to the v2.0.2 (tentative) milestone Dec 3, 2024
AkihiroSuda
AkihiroSuda approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 6537124 into containerd:main Dec 3, 2024
30 checks passed
@github-actions github-actions bot mentioned this pull request Dec 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonBarkan RonBarkan RonBarkan approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging this pull request may close these issues.

nerdctl error message provides no context
3 participants
@apostasie @AkihiroSuda @RonBarkan