Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support creating container with labels defined by image #3023

Merged
merged 1 commit into from
May 20, 2024
Merged

feat: Support creating container with labels defined by image #3023

merged 1 commit into from
May 20, 2024

Conversation

yankay
Copy link
Contributor

@yankay yankay commented May 20, 2024

Support creating container with labels defined by image.
So, the image label can be inspected by nerdctl inspect container-name

fix: #2996

@yankay yankay force-pushed the add-image-label branch from 4a0a980 to e5dc086 Compare May 20, 2024 11:28
@yankay
support image label
cf5073b 
Signed-off-by: Kay Yan <[email protected]>
@yankay yankay force-pushed the add-image-label branch from e5dc086 to cf5073b Compare May 20, 2024 12:06
AkihiroSuda
AkihiroSuda approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone May 20, 2024
@AkihiroSuda AkihiroSuda merged commit 3dfdf55 into containerd:main May 20, 2024
22 checks passed
@apostasie
Copy link
Contributor

Thanks a lot @yankay !

@github-actions github-actions bot mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

nerdctl does not create labels defined by image
3 participants
@yankay @apostasie @AkihiroSuda