doc: Document new cli option for specifying configuration path (#528) #265
main.yaml
on: push
lint-test-release
3m 8s
build-musl
1m 3s
Matrix: build
Annotations
108 warnings
build-musl
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
this boolean expression can be simplified:
app/src/config/mod.rs#L245
warning: this boolean expression can be simplified
--> app/src/config/mod.rs:245:17
|
245 | assert!(!result.is_err());
| ^^^^^^^^^^^^^^^^ help: try: `result.is_ok()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
= note: `#[warn(clippy::nonminimal_bool)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/config/mod.rs#L98
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/config/mod.rs:98:37
|
98 | let config = match find_configs(&args) {
| ^^^^^ help: change this to: `args`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/config/mod.rs#L66
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/config/mod.rs:66:22
|
66 | match lib_config(&args) {
| ^^^^^ help: change this to: `args`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/config/mod.rs#L98
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/config/mod.rs:98:37
|
98 | let config = match find_configs(&args) {
| ^^^^^ help: change this to: `args`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/config/mod.rs#L66
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/config/mod.rs:66:22
|
66 | match lib_config(&args) {
| ^^^^^ help: change this to: `args`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/commands/apply.rs#L90
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/commands/apply.rs:90:48
|
90 | let manifest_path = self.manifest_path(&runtime)?;
| ^^^^^^^^ help: change this to: `runtime`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
useless use of `format!`:
app/src/commands/apply.rs#L77
warning: useless use of `format!`
--> app/src/commands/apply.rs:77:27
|
77 | Cell::new(format!("{name}")),
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/commands/apply.rs#L63
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/commands/apply.rs:63:48
|
63 | let manifest_path = self.manifest_path(&runtime)?;
| ^^^^^^^^ help: change this to: `runtime`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/commands/apply.rs#L90
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/commands/apply.rs:90:48
|
90 | let manifest_path = self.manifest_path(&runtime)?;
| ^^^^^^^^ help: change this to: `runtime`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
useless use of `format!`:
app/src/commands/apply.rs#L77
warning: useless use of `format!`
--> app/src/commands/apply.rs:77:27
|
77 | Cell::new(format!("{name}")),
| ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `name.to_string()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: `#[warn(clippy::useless_format)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
app/src/commands/apply.rs#L63
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> app/src/commands/apply.rs:63:48
|
63 | let manifest_path = self.manifest_path(&runtime)?;
| ^^^^^^^^ help: change this to: `runtime`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
calls to `push` immediately after creation:
lib/src/contexts/privilege.rs#L44
warning: calls to `push` immediately after creation
--> lib/src/contexts/privilege.rs:44:9
|
44 | / let mut contexts = vec![];
45 | |
46 | | contexts.push(Context::KeyValueContext(
47 | | "privilege".to_string(),
48 | | self.config.privilege.to_string().into(),
49 | | ));
| |___________^ help: consider using the `vec![]` macro: `let contexts = vec![..];`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
= note: `#[warn(clippy::vec_init_then_push)]` on by default
|
this `impl` can be derived:
lib/src/contexts/privilege.rs#L17
warning: this `impl` can be derived
--> lib/src/contexts/privilege.rs:17:1
|
17 | / impl Default for Privilege {
18 | | fn default() -> Self {
19 | | Privilege::Sudo
20 | | }
21 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
6 + #[derive(Default)]
7 | pub enum Privilege {
|
help: ...and mark the default variant
|
8 ~ #[default]
9 ~ Sudo,
|
|
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`:
lib/src/atoms/command/exec.rs#L116
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
--> lib/src/atoms/command/exec.rs:116:23
|
116 | let command = utilities::get_binary_path(&command)
| _______________________^
117 | | .or_else(|_| Err(anyhow!("Command `{}` not found in path", command)))?;
| |_________________________________________________________________________________^ help: try: `utilities::get_binary_path(&command).map_err(|_| anyhow!("Command `{}` not found in path", command))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
|
calls to `push` immediately after creation:
lib/src/contexts/privilege.rs#L44
warning: calls to `push` immediately after creation
--> lib/src/contexts/privilege.rs:44:9
|
44 | / let mut contexts = vec![];
45 | |
46 | | contexts.push(Context::KeyValueContext(
47 | | "privilege".to_string(),
48 | | self.config.privilege.to_string().into(),
49 | | ));
| |___________^ help: consider using the `vec![]` macro: `let contexts = vec![..];`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
= note: `#[warn(clippy::vec_init_then_push)]` on by default
|
this `impl` can be derived:
lib/src/contexts/privilege.rs#L17
warning: this `impl` can be derived
--> lib/src/contexts/privilege.rs:17:1
|
17 | / impl Default for Privilege {
18 | | fn default() -> Self {
19 | | Privilege::Sudo
20 | | }
21 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
6 + #[derive(Default)]
7 | pub enum Privilege {
|
help: ...and mark the default variant
|
8 ~ #[default]
9 ~ Sudo,
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/macos.rs#L97
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/macos.rs:97:47
|
97 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/macos.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/macos.rs:69:57
|
69 | for group in self.add_to_group(&user_group, &contexts)? {
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/macos.rs#L49
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/macos.rs:49:47
|
49 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/linux.rs#L99
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/linux.rs:99:47
|
99 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/linux.rs#L71
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/linux.rs:71:58
|
71 | for group in self.add_to_group(&user_groups, &contexts)? {
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/linux.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/linux.rs:51:47
|
51 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/freebsd.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/freebsd.rs:91:47
|
91 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/freebsd.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/freebsd.rs:69:58
|
69 | for group in self.add_to_group(&user_groups, &contexts)? {
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/freebsd.rs#L46
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/freebsd.rs:46:47
|
46 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/add_group.rs#L30
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/add_group.rs:30:55
|
30 | atoms.append(&mut provider.add_to_group(self, &context)?);
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/add.rs#L29
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/add.rs:29:67
|
29 | None => atoms.append(&mut provider.add_user(&variant, &context)?),
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
using `clone` on type `bool` which implements the `Copy` trait:
lib/src/actions/package/mod.rs#L94
warning: using `clone` on type `bool` which implements the `Copy` trait
--> lib/src/actions/package/mod.rs:94:19
|
94 | file: package.file.clone(),
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`:
lib/src/atoms/command/exec.rs#L116
warning: using `Result.or_else(|x| Err(y))`, which is more succinctly expressed as `map_err(|x| y)`
--> lib/src/atoms/command/exec.rs:116:23
|
116 | let command = utilities::get_binary_path(&command)
| _______________________^
117 | | .or_else(|_| Err(anyhow!("Command `{}` not found in path", command)))?;
| |_________________________________________________________________________________^ help: try: `utilities::get_binary_path(&command).map_err(|_| anyhow!("Command `{}` not found in path", command))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map
= note: `#[warn(clippy::bind_instead_of_map)]` on by default
|
using `clone` on type `bool` which implements the `Copy` trait:
lib/src/actions/package/mod.rs#L80
warning: using `clone` on type `bool` which implements the `Copy` trait
--> lib/src/actions/package/mod.rs:80:23
|
80 | file: package.file.clone(),
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/repository.rs#L62
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/repository.rs:62:61
|
62 | atoms.append(&mut provider.add_repository(self, &context)?);
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/repository.rs#L58
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/repository.rs:58:50
|
58 | atoms.append(&mut provider.bootstrap(&context));
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/repository.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/repository.rs:51:35
|
51 | if provider.bootstrap(&context).is_empty() {
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/zypper.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/zypper.rs:51:47
|
51 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/xbps.rs#L102
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/xbps.rs:102:47
|
102 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/macos.rs#L97
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/macos.rs:97:47
|
97 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/yay.rs#L35
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/yay.rs:35:47
|
35 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/macos.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/macos.rs:69:57
|
69 | for group in self.add_to_group(&user_group, &contexts)? {
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/macos.rs#L49
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/macos.rs:49:47
|
49 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/snapcraft.rs#L68
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/snapcraft.rs:68:47
|
68 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/snapcraft.rs#L31
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/snapcraft.rs:31:47
|
31 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/linux.rs#L99
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/linux.rs:99:47
|
99 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/pkgin.rs#L57
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/pkgin.rs:57:47
|
57 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/linux.rs#L71
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/linux.rs:71:58
|
71 | for group in self.add_to_group(&user_groups, &contexts)? {
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/linux.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/linux.rs:51:47
|
51 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/paru.rs#L35
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/paru.rs:35:47
|
35 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| String::from("sudo"));
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/freebsd.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/freebsd.rs:91:47
|
91 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/macports.rs#L61
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/macports.rs:61:47
|
61 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/freebsd.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/freebsd.rs:69:58
|
69 | for group in self.add_to_group(&user_groups, &contexts)? {
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/providers/freebsd.rs#L46
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/providers/freebsd.rs:46:47
|
46 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/add_group.rs#L30
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/add_group.rs:30:55
|
30 | atoms.append(&mut provider.add_to_group(self, &context)?);
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/user/add.rs#L29
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/user/add.rs:29:67
|
29 | None => atoms.append(&mut provider.add_user(&variant, &context)?),
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
using `clone` on type `bool` which implements the `Copy` trait:
lib/src/actions/package/mod.rs#L94
warning: using `clone` on type `bool` which implements the `Copy` trait
--> lib/src/actions/package/mod.rs:94:19
|
94 | file: package.file.clone(),
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
|
using `clone` on type `bool` which implements the `Copy` trait:
lib/src/actions/package/mod.rs#L80
warning: using `clone` on type `bool` which implements the `Copy` trait
--> lib/src/actions/package/mod.rs:80:23
|
80 | file: package.file.clone(),
| ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `package.file`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
= note: `#[warn(clippy::clone_on_copy)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/dnf.rs#L125
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/dnf.rs:125:47
|
125 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/dnf.rs#L63
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/dnf.rs:63:47
|
63 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/dnf.rs#L32
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/dnf.rs:32:47
|
32 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/bsdpkg.rs#L75
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/bsdpkg.rs:75:47
|
75 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/bsdpkg.rs#L39
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/bsdpkg.rs:39:47
|
39 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
`assert!(false)` should probably be replaced:
lib/src/actions/package/providers/aptitude.rs#L258
warning: `assert!(false)` should probably be replaced
--> lib/src/actions/package/providers/aptitude.rs:258:13
|
258 | assert!(false);
| ^^^^^^^^^^^^^^
|
= help: use `panic!()` or `unreachable!()`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
= note: `#[warn(clippy::assertions_on_constants)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/aptitude.rs#L146
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/aptitude.rs:146:47
|
146 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/aptitude.rs#L77
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/aptitude.rs:77:47
|
77 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/repository.rs#L62
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/repository.rs:62:61
|
62 | atoms.append(&mut provider.add_repository(self, &context)?);
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/repository.rs#L58
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/repository.rs:58:50
|
58 | atoms.append(&mut provider.bootstrap(&context));
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/aptitude.rs#L41
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/aptitude.rs:41:47
|
41 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/repository.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/repository.rs:51:35
|
51 | if provider.bootstrap(&context).is_empty() {
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/install.rs#L61
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/install.rs:61:54
|
61 | atoms.append(&mut provider.install(&variant, &context)?);
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/install.rs#L58
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/install.rs:58:50
|
58 | atoms.append(&mut provider.bootstrap(&context));
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/install.rs#L36
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/install.rs:36:35
|
36 | if provider.bootstrap(&context).is_empty() {
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/zypper.rs#L51
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/zypper.rs:51:47
|
51 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/xbps.rs#L102
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/xbps.rs:102:47
|
102 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/providers/macos.rs#L37
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/providers/macos.rs:37:47
|
37 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/providers/linux.rs#L28
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/providers/linux.rs:28:47
|
28 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/providers/freebsd.rs#L19
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/providers/freebsd.rs:19:47
|
19 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/yay.rs#L35
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/yay.rs:35:47
|
35 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/add.rs#L23
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/add.rs:23:56
|
23 | atoms.append(&mut provider.add_group(&variant, &contexts));
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/snapcraft.rs#L68
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/snapcraft.rs:68:47
|
68 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/snapcraft.rs#L31
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/snapcraft.rs:31:47
|
31 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/pkgin.rs#L57
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/pkgin.rs:57:47
|
57 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/paru.rs#L35
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/paru.rs:35:47
|
35 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| String::from("sudo"));
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/macports.rs#L61
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/macports.rs:61:47
|
61 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/dnf.rs#L125
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/dnf.rs:125:47
|
125 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/dnf.rs#L63
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/dnf.rs:63:47
|
63 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/dnf.rs#L32
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/dnf.rs:32:47
|
32 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/bsdpkg.rs#L75
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/bsdpkg.rs:75:47
|
75 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/bsdpkg.rs#L39
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/bsdpkg.rs:39:47
|
39 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/aptitude.rs#L146
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/aptitude.rs:146:47
|
146 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/aptitude.rs#L77
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/aptitude.rs:77:47
|
77 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/providers/aptitude.rs#L41
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/providers/aptitude.rs:41:47
|
41 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/install.rs#L61
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/install.rs:61:54
|
61 | atoms.append(&mut provider.install(&variant, &context)?);
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/install.rs#L58
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/install.rs:58:50
|
58 | atoms.append(&mut provider.bootstrap(&context));
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/package/install.rs#L36
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/package/install.rs:36:35
|
36 | if provider.bootstrap(&context).is_empty() {
| ^^^^^^^^ help: change this to: `context`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
single-character string constant used as pattern:
lib/src/actions/directory/copy.rs#L49
warning: single-character string constant used as pattern
--> lib/src/actions/directory/copy.rs:49:30
|
49 | if self.to.ends_with("/") {
| ^^^ help: consider using a `char`: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/command/run.rs#L46
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/command/run.rs:46:47
|
46 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/providers/macos.rs#L37
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/providers/macos.rs:37:47
|
37 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/providers/linux.rs#L28
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/providers/linux.rs:28:47
|
28 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/providers/freebsd.rs#L19
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/providers/freebsd.rs:19:47
|
19 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/group/add.rs#L23
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/group/add.rs:23:56
|
23 | atoms.append(&mut provider.add_group(&variant, &contexts));
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
single-character string constant used as pattern:
lib/src/actions/directory/copy.rs#L49
warning: single-character string constant used as pattern
--> lib/src/actions/directory/copy.rs:49:30
|
49 | if self.to.ends_with("/") {
| ^^^ help: consider using a `char`: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
this expression creates a reference which is immediately dereferenced by the compiler:
lib/src/actions/command/run.rs#L46
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> lib/src/actions/command/run.rs:46:47
|
46 | utilities::get_privilege_provider(&contexts).unwrap_or_else(|| "sudo".to_string());
| ^^^^^^^^^ help: change this to: `contexts`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
this import is redundant:
lib/src/utilities/mod.rs#L2
warning: this import is redundant
--> lib/src/utilities/mod.rs:2:1
|
2 | use which;
| ^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|
this import is redundant:
lib/src/utilities/mod.rs#L2
warning: this import is redundant
--> lib/src/utilities/mod.rs:2:1
|
2 | use which;
| ^^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
|
lint-test-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-test-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-test-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-test-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lint-test-release
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|