Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pm2 detectors #295

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add pm2 detectors #295

wants to merge 2 commits into from

Conversation

jphilaine
Copy link
Contributor

No description provided.

Copy link
Contributor

@xp-1000 xp-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions here

@@ -0,0 +1,14 @@
## Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this ;)

@@ -0,0 +1,15 @@
module: pm2
name: "up application"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "up application"
name: "application status"

?

@@ -0,0 +1,3 @@
documentations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be good to add some information how to setup pm2 metrics with an example of agent configuration to fetch them.

also it seems useful to explain why (not filter('name', 'pm2-metrics')) is required

@pdecat pdecat added the detectors About nex or existing detectors label Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detectors About nex or existing detectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants