Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More new types for 1.0.x minor release #194

Merged
merged 4 commits into from
May 28, 2020

Conversation

bwiernik
Copy link
Member

@bwiernik bwiernik commented May 24, 2020

Separate PRs coming for variables and terms.

Compiled from discussions on csl-evolution, zotero-bits, schema, and documentation. Also from the CSL-M spec.

  1. performance is needed for live performances. Arts and musicology styles have distinct formatting rules for live performances versus conference-style presentations
  2. periodical is for references to whole periodicals (e.g., a run of a journal, a special issue)
  3. collection is for museum or archival collections. I believe that this would also cover citation of exhibitions/exhibit catalogues (@adam3smith?)
  4. hearing and regulation are legal types with distinct citation needs that bill or legislation (e.g., Congressional hearings).
  5. classic refers to ancient works with unique citation forms versus modern works (widely used in classical and biblical studies, for example).

Two CSL-M types I omitted:

  1. video:
    • Defined as "The video type is appropriate for video works that are not disseminated through an access-restricted distribution channel. For example, content hosted on YouTube should be set to video, while a DVD release of “The Wizard of Oz” should be set to motion_picture."
    • I don't think this is a meaningful distinction, and I'm not sure that such a distinction is required by citation styles.
  2. gazette:
    • A specific pubication format for some legal items
    • Appears to be superseded by a gazette-flag variable that might be assigned for types legislation or regulation.

Closes citation-style-language/csl-evolution#22
Closes #22

Addresses #95

I've tagged zotero-bits issues with a zotero tag to indicate that all that remains on them is Zotero implementation.

Compiled from discussions on csl-evolution, zotero-bits, schema, and documentation. Also from the CSL-M spec.

1. `performance` is needed for live performances. Arts and musicology styles have distinct formatting rules for live performances versus conference-style presentations
2. `perdiodical` is for references to whole periodicals (e.g., a run of a journal, a special issue)
3. `collection` is for museum or archival collections. I believe that this would also cover citation of exhibitions/exhibit catalogues (@adam3smith?)
4. `hearing` and `regulation` are legal types with distinct citation needs that `bill` or `legislation` (e.g.,
5. `classic` refers to ancient works with unique citation forms versus modern works

Two CSL-M types I omitted:
1. `video`:
    - Defined as "The video type is appropriate for video works that are not disseminated through an access-restricted distribution channel. For example, content hosted on YouTube should be set to `video`, while a DVD release of “The Wizard of Oz” should be set to `motion_picture`."
    - I don't think this is a meaningful distinction, and I'm not sure that such a distinction is required by citation styles.
1. `gazette`:
    - A specific pubication format for some legal items
    - Appears to be superseded by a `gazette-flag` variable that might be assigned for types `legislation` or `regulation`.
@bdarcus bdarcus requested review from adam3smith, fbennett, rmzelle and a team May 25, 2020 01:01
@bdarcus
Copy link
Member

bdarcus commented May 25, 2020

I requested reviews from a few people. Hoping they can do this sometime during the coming week.

Copy link
Member

@bdarcus bdarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do any of these close existing issues we control?

If yes, see this:

https://help.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords

Also, I think the actual commit message can omit some of the details on the PR submission message.

You can amend the latest commit message like this:

git commit --amend
git push --force

@bwiernik
Copy link
Member Author

Where do we stand on closing the zotero-bits issues that also entail Zotero changes?

@bdarcus
Copy link
Member

bdarcus commented May 25, 2020 via email

@denismaier
Copy link
Member

Obviously we wouldn't want to close them, but we could link from here. We should also probably transfer those to Zotero?

We've had some discussion about this a couple of weeks ago, right?

Perhaps we can just transfer the whole repo to Zotero once we've dealt with the CSL part...

@bwiernik
Copy link
Member Author

bwiernik commented May 25, 2020

@bdarcus Could you give me editing rights To that repo so I can add a “zotero” tag to issues as we resolve them?

@bdarcus
Copy link
Member

bdarcus commented May 25, 2020

I just gave you "triage" rights, which I think works for what you need. Let me know if not.

@bwiernik
Copy link
Member Author

Updated the commit comment to close issues. For zotero-bits issues, I added zotero tags.

(By the way, for the extended commit comments, you can edit them directly on GitHub, rather than having to use git commands.)

@bdarcus
Copy link
Member

bdarcus commented May 25, 2020

I don't see any changes ATM. Latest commit says yesterday.

@bwiernik
Copy link
Member Author

I just updated the commit comment, didn't make a new commit. The bottom of the commit comment now closes 2 issues.

csl-types.rnc Outdated Show resolved Hide resolved
@bwiernik
Copy link
Member Author

Ah, sorry. The vertical bars overlapped with my editor’s indentation guides and I didn’t notice.

@rmzelle
Copy link
Member

rmzelle commented May 25, 2020

Perhaps we can just transfer the whole repo to Zotero once we've dealt with the CSL part...

Dan Stillman actually asked for this here: zotero/zotero-bits#73 (comment)

@bwiernik
Copy link
Member Author

Yeah, so once we've finished tagging everything with zotero, we can transfer it to them.

csl-data.json Show resolved Hide resolved
csl-data.json Show resolved Hide resolved
csl-data.json Show resolved Hide resolved
Copy link
Member

@bdarcus bdarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a few comments to align the two schemas.

@bdarcus bdarcus merged commit 4b35f4f into citation-style-language:master May 28, 2020
@bdarcus
Copy link
Member

bdarcus commented May 28, 2020

OK, merged. Thanks.

Note, I simplified the commit message, since that info is included here.

@bdarcus bdarcus mentioned this pull request Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "archival-collection" item type Item type for classical works
4 participants