-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More new types for 1.0.x minor release #194
Conversation
Compiled from discussions on csl-evolution, zotero-bits, schema, and documentation. Also from the CSL-M spec. 1. `performance` is needed for live performances. Arts and musicology styles have distinct formatting rules for live performances versus conference-style presentations 2. `perdiodical` is for references to whole periodicals (e.g., a run of a journal, a special issue) 3. `collection` is for museum or archival collections. I believe that this would also cover citation of exhibitions/exhibit catalogues (@adam3smith?) 4. `hearing` and `regulation` are legal types with distinct citation needs that `bill` or `legislation` (e.g., 5. `classic` refers to ancient works with unique citation forms versus modern works Two CSL-M types I omitted: 1. `video`: - Defined as "The video type is appropriate for video works that are not disseminated through an access-restricted distribution channel. For example, content hosted on YouTube should be set to `video`, while a DVD release of “The Wizard of Oz” should be set to `motion_picture`." - I don't think this is a meaningful distinction, and I'm not sure that such a distinction is required by citation styles. 1. `gazette`: - A specific pubication format for some legal items - Appears to be superseded by a `gazette-flag` variable that might be assigned for types `legislation` or `regulation`.
I requested reviews from a few people. Hoping they can do this sometime during the coming week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do any of these close existing issues we control?
If yes, see this:
Also, I think the actual commit message can omit some of the details on the PR submission message.
You can amend the latest commit message like this:
git commit --amend
git push --force
Where do we stand on closing the zotero-bits issues that also entail Zotero changes? |
Obviously we wouldn't want to close them, but we could link from here.
We should also probably transfer those to Zotero?
|
We've had some discussion about this a couple of weeks ago, right? Perhaps we can just transfer the whole repo to Zotero once we've dealt with the CSL part... |
@bdarcus Could you give me editing rights To that repo so I can add a “zotero” tag to issues as we resolve them? |
I just gave you "triage" rights, which I think works for what you need. Let me know if not. |
Updated the commit comment to close issues. For zotero-bits issues, I added (By the way, for the extended commit comments, you can edit them directly on GitHub, rather than having to use git commands.) |
I don't see any changes ATM. Latest commit says yesterday. |
I just updated the commit comment, didn't make a new commit. The bottom of the commit comment now closes 2 issues. |
Ah, sorry. The vertical bars overlapped with my editor’s indentation guides and I didn’t notice. |
Dan Stillman actually asked for this here: zotero/zotero-bits#73 (comment) |
Yeah, so once we've finished tagging everything with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a few comments to align the two schemas.
OK, merged. Thanks. Note, I simplified the commit message, since that info is included here. |
Separate PRs coming for variables and terms.
Compiled from discussions on csl-evolution, zotero-bits, schema, and documentation. Also from the CSL-M spec.
performance
is needed for live performances. Arts and musicology styles have distinct formatting rules for live performances versus conference-style presentationsperiodical
is for references to whole periodicals (e.g., a run of a journal, a special issue)collection
is for museum or archival collections. I believe that this would also cover citation of exhibitions/exhibit catalogues (@adam3smith?)hearing
andregulation
are legal types with distinct citation needs thatbill
orlegislation
(e.g., Congressional hearings).classic
refers to ancient works with unique citation forms versus modern works (widely used in classical and biblical studies, for example).Two CSL-M types I omitted:
video
:video
, while a DVD release of “The Wizard of Oz” should be set tomotion_picture
."gazette
:gazette-flag
variable that might be assigned for typeslegislation
orregulation
.Closes citation-style-language/csl-evolution#22
Closes #22
Addresses #95
I've tagged zotero-bits issues with a
zotero
tag to indicate that all that remains on them is Zotero implementation.