Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cookbook details slider. #5553

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Added cookbook details slider. #5553

merged 3 commits into from
Aug 23, 2021

Conversation

himanshi-chhabra
Copy link
Contributor

@himanshi-chhabra himanshi-chhabra commented Aug 23, 2021

Signed-off-by: Himanshi Chhabra [email protected]

🔩 Description: What code changed, and why?

  • Add the link to a cookbook to open a slider with the details page of the cookbook
  • Add Go to details button to open a detail page of cookbook

⛓️ Related Resources

#5470

👍 Definition of Done

  • Added the link to a cookbook to open a slider with the details page of the cookbook
  • Added Go to details button to open a detail page of the cookbook
  • Added cypress test cases slider and button

👟 How to Build and Test the Change

STEP 1
inside the hab studio

[default:/src:0]# build components/automate-ui-devproxy/
[default:/src:0]# start_automate_ui_background
[default:/src:0]# start_all_services

STEP 2
open new window
go to automate UI path

$ cd components/automate-ui
and run the command 

npm run serve:hab

To add data https://github.com/chef/automate/blob/master/dev-docs/adding-data/adding_test_data.md#adding-data-to-infra-views
Steps for policy file tab:

  1. Go To Infrastructure -> Chef Servers -> click server name-> click on org name -> policyfile tab.
  2. Will see the policy file if available else will see no preview.
  3. if available click on policy file name -> will see details page
  4. click on Cookbook Dependencies button ->
  5. Opens a slider with Cookbook accordion which has cookbooks on the table.

✅ Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

📷 Screenshots, if applicable

  • Opens a slider with clickable and opens cookbook details page.
cookbook-details.mp4
  • Cookbook details give a customized message if the version is not correct.
details-error.mp4

@himanshi-chhabra himanshi-chhabra added ui automate-ui cypress automate-infra-proxy Team: Stalwart Migrate Chef Manage, UI bugs, UX improvements, CVE Issues labels Aug 23, 2021
@himanshi-chhabra himanshi-chhabra self-assigned this Aug 23, 2021
@netlify
Copy link

netlify bot commented Aug 23, 2021

👷 Deploy Preview for chef-automate processing.

🔨 Explore the source changes: 2cf5c54

🔍 Inspect the deploy log: https://app.netlify.com/sites/chef-automate/deploys/61239f1182cc29000709d696

@himanshi-chhabra himanshi-chhabra force-pushed the Himanshi/cookbookdetails branch from 1adaa9b to 836d3b0 Compare August 23, 2021 12:42
@chaitali-mane
Copy link
Contributor

Can we add underline below name and curser link
image

@chaitali-mane
Copy link
Contributor

Table heading and data are not aligned, same in cookbooks tab also. Can this get properly aligned
image

Signed-off-by: Himanshi Chhabra <[email protected]>
@himanshi-chhabra
Copy link
Contributor Author

Can we add underline below name and curser link
image

I have updated the changes.

@himanshi-chhabra
Copy link
Contributor Author

Table heading and data are not aligned, same in cookbooks tab also. Can this get properly aligned
image

we can't make this change now as in the cookbook tab also we have this issue and this has been written in stencil not from our css so we need some time for that will try to take this on the next sprint.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kalroy kalroy merged commit 1d42679 into master Aug 23, 2021
@kalroy kalroy deleted the Himanshi/cookbookdetails branch August 23, 2021 16:45
@dishanktiwari2501 dishanktiwari2501 mentioned this pull request Sep 7, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants