-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd: replace Manager.DeleteVolumeGroup() by VolumeGroup.Delete() #4872
Conversation
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at f2bc1c6 |
There is no need for the `Manager.DeleteVolumeGroup()` function as `VolumeGroup.Delete()` should cover everything too. By moving the `.Delete()` functionality of removing the group from the journal to the shared `commonVolumeGroup` type, a volume group snaphot can use it as well. Signed-off-by: Niels de Vos <[email protected]>
0d4b611
to
77d6c85
Compare
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/k8s-e2e-external-storage/1.31 |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/mini-e2e-helm/k8s-1.31 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/mini-e2e/k8s-1.31 |
/test ci/centos/mini-e2e/k8s-1.30 |
/test ci/centos/k8s-e2e-external-storage/1.29 |
/test ci/centos/mini-e2e-helm/k8s-1.29 |
/test ci/centos/mini-e2e/k8s-1.29 |
There is no need for the
Manager.DeleteVolumeGroup()
function asVolumeGroup.Delete()
should cover everything too.By moving the
.Delete()
functionality of removing the group from thejournal to the shared
commonVolumeGroup
type, a volume group snaphotcan use it as well.
Signed-off-by: Niels de Vos [email protected]