Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: replace Manager.DeleteVolumeGroup() by VolumeGroup.Delete() #4872

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

nixpanic
Copy link
Member

There is no need for the Manager.DeleteVolumeGroup() function as
VolumeGroup.Delete() should cover everything too.

By moving the .Delete() functionality of removing the group from the
journal to the shared commonVolumeGroup type, a volume group snaphot
can use it as well.

Signed-off-by: Niels de Vos [email protected]

@mergify mergify bot added the component/rbd Issues related to RBD label Sep 26, 2024
@Madhu-1 Madhu-1 requested a review from a team September 26, 2024 08:28
@nixpanic
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Sep 26, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f2bc1c6

There is no need for the `Manager.DeleteVolumeGroup()` function as
`VolumeGroup.Delete()` should cover everything too.

By moving the `.Delete()` functionality of removing the group from the
journal to the shared `commonVolumeGroup` type, a volume group snaphot
can use it as well.

Signed-off-by: Niels de Vos <[email protected]>
@nixpanic nixpanic force-pushed the rbd/remove-DeleteVolumeGroup branch from 0d4b611 to 77d6c85 Compare September 26, 2024 11:53
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Sep 26, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Sep 26, 2024
@mergify mergify bot merged commit f2bc1c6 into ceph:devel Sep 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rbd Issues related to RBD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants