Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Microsoft extensions on argument-type: 'w', 'I', 'I32', 'I64' #44

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

jeking3
Copy link
Contributor

@jeking3 jeking3 commented Oct 24, 2017

Argument types in format specifications are ignored by boost::format because the argument type is carried through the conversion by operator %. This change allows boost::format to parse through format strings with Microsoft specific argument types without throwing an exception.

With-Commit-String values are from msvc-14.1 using default en_US locale.

String Data Pre-Commit With-Commit-String
%wc '5' boost::bad_format_string: format-string is ill-formed 5
%Id 12345 boost::bad_format_string: format-string is ill-formed 12345
%I32d 12345 boost::bad_format_string: format-string is ill-formed 12345
%I64d 1234567890123 boost::bad_format_string: format-string is ill-formed 1234567890123

This closes #35

@jeking3 jeking3 added this to the v1.66.0 milestone Oct 24, 2017
@jeking3 jeking3 self-assigned this Oct 24, 2017
@jeking3
Copy link
Contributor Author

jeking3 commented Oct 24, 2017

Travis is moving at snails pace today and this passes the CI build in my fork, so I'm going to merge it.

@jeking3 jeking3 merged commit bf6016c into boostorg:develop Oct 24, 2017
@jeking3 jeking3 deleted the issue-35 branch October 24, 2017 20:57
jeking3 pushed a commit to jeking3/format that referenced this pull request Jun 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Microsoft extension argument size modifiers (I, I32, I64)
1 participant