add support for parsing (and ignoring) argument types 'j', 'z' #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build has been in the queue for 3 hours so I ran it on my fork and it's fine. Moving on.. |
jeking3
pushed a commit
to jeking3/format
that referenced
this pull request
Jun 17, 2018
Fixed integer overflow when subtracting many years to a gregorian date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument types in format specifications are ignored by boost::format because the argument type is carried through the conversion by
operator %. Type't'is already used as a conversion specifier for tabulation therefore we only added what was missing, which was'j'and'z'.With-Commit values are from msvc-14.1.
%jdstd::numeric_limits<intmax_t>::max() - 123459223372036854763462%zustd::numeric_limits<size_t>::max() - 123454294954950(Remember that size_t on Windows is 32-bit)
This closes #29