-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support preferred vocabulary name #17
feat: support preferred vocabulary name #17
Conversation
✅ Deploy Preview for sprkls ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I noticed that |
I might be misunderstanding something but wouldn't the results from the query like in your example mean that the server only supports As for the SharePage, that's specifically triggered when sparkles is installed as a PWA and you use it as a share target. A way to preview it would be to go to the route directly: https://sparkles.sploot.com/share?url=https://benji.dog |
Correct. Ideally, if a sever returns a |
ae1b3c3
to
a4a3fca
Compare
a4a3fca
to
d6dfdf6
Compare
I’ve added some code to prevent showing a tile on the home page if there’s a And looking at the |
Thanks! Took your ideas and ran with it. I've now moved the rendering of the Tiles to a single component that will use the I also made sure that the titles of each editor uses the I'll wait to hear back on your thoughts before merging just in case something is missing. |
Oh, nice. Yeah, updating the titles is a good idea too. Just tested this and spotted 2 issues:
|
Good catch. I have the tiles redrawing after the config is loaded now so that should display the tiles correctly. |
Excellent. 🚢! |
This PR adds support for querying for supported vocabularies and using any preferred names for relevant post types in Sparkles’ interface.
For example, querying my test endpoint, I get the following response (truncated, only relevant objects shown):
This results in the interface adapting such that ‘Favourite’ is shown instead of ‘Like’ and ‘Film’ is shown instead of ‘Movie’: