Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stubbed init code #622

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

mistydemeo
Copy link
Contributor

After experimenting with some changes here, I think I've concluded we don't want this in init. Otherwise, our toml_edit code will reformat it into the less pretty syntax:

github-custom-runners = { aarch64-unknown-linux-gnu = "buildjet-16vcpu-ubuntu-2204-arm" }

instead of

[workspace.metadata.dist.github-custom-runners]
aarch64-unknown-linux-gnu = "buildjet-16vcpu-ubuntu-2204-arm"

@mistydemeo mistydemeo requested a review from Gankra December 4, 2023 23:31
@Gankra
Copy link
Contributor

Gankra commented Dec 5, 2023

There aughta be a way to tell cargo-fmt which style we want (essentially picking one to be "canonical"), but yeah turning this off for now is fine (we have a similar issue with targets having pretty user formatting stripped, so more elbow grease in Good Formatting would be good to do next quarter).

@mistydemeo mistydemeo merged commit 824ed17 into main Dec 5, 2023
@mistydemeo mistydemeo deleted the custom_runners_followup branch December 5, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants