Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: set CC/CXX in generic builds #616

Merged
merged 1 commit into from
Nov 28, 2023
Merged

feat: set CC/CXX in generic builds #616

merged 1 commit into from
Nov 28, 2023

Conversation

mistydemeo
Copy link
Contributor

Currently, we don't set CC or CXX when running generic builds. This is fine most of the time, but for makefile builds we probably want to hint at the makefile which platform-specific compiler should be used.

This respects CC and CXX from the external environment if set.

@mistydemeo mistydemeo force-pushed the generic-builds-compilers branch from 489cef4 to b58a529 Compare November 28, 2023 17:37
@mistydemeo mistydemeo merged commit 67d3094 into main Nov 28, 2023
14 checks passed
@mistydemeo mistydemeo deleted the generic-builds-compilers branch November 28, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gankra Gankra Gankra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistydemeo @Gankra