Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Linuxbrew #561

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Add support for Linuxbrew #561

merged 4 commits into from
Nov 27, 2023

Conversation

dsully
Copy link
Contributor

@dsully dsully commented Nov 10, 2023

First pass at adding Linuxbrew support.

Use on_macos/on_linux and on_arm/on_intel as Homebrew stanzas instead of Hardware::CPU.type

Update insta snaps.

Fixes #501

@dsully
Add support for Linuxbrew
cad3000 
Use on_macos/on_linux and on_arm/on_intel as Homebrew stanzas instead of Hardware::CPU.type

Update insta snaps.
mistydemeo
mistydemeo reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I'll do a more thorough review tomorrow, but I really appreciate the contribution.

mistydemeo
mistydemeo requested changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Just a few minor comments.

Again, I really appreciate the contribution.

@dsully
Copy link
Contributor Author

dsully commented Nov 17, 2023

Thanks for catching those missing do statements. Updated along with the name fixes.

mistydemeo
mistydemeo reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

We're cutting a new release soon, so I'll get this merged after that. Do you mind rebasing on main and updating the test fixtures with the template change you made in the last commit?

@dsully
Copy link
Contributor Author

dsully commented Nov 20, 2023

Done, just pushed another commit.

mistydemeo
mistydemeo approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! I'll get this merged after 0.5.0 is released.

@mistydemeo mistydemeo merged commit 71a9a02 into axodotdev:main Nov 27, 2023
@mistydemeo
Copy link
Contributor

Thanks again! We'll include this in a future release, most likely 0.6.0.

@dsully
Copy link
Contributor Author

dsully commented Nov 27, 2023

Thanks, looking forward to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistydemeo mistydemeo mistydemeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linuxbrew Support
2 participants
@dsully @mistydemeo