[MERGE AFTER #868] fix type hints when using postponed evaluation of annotations (PEP-563) #840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
typing.get_type_hints
instead ofinspect.signature
since the former will try toeval
string type hints (PEP-563) and will return an object rather than a string if it was successful which will allow the remaining code to work.inspect.signature
on the other hand does not have the ability to resolve string type hints until Python 3.10 and has to be called witheval_str=True
This also partially reverts #428, but fixes #426 correctly by not failing on the
isclass(hint_class)
check due to annotations not "really" being classes.This latter change is done because
list[str]
is unconditionally and improperly unwrapped and will result in a type ofstr
sincelist
's annotations will also have a first argument ofstr
.