Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GRIFFIN-365] Measure Enhancements and Stability fixes #593

Merged
merged 8 commits into from
Oct 4, 2021

Conversation

chitralverma
Copy link
Contributor

@chitralverma chitralverma commented Sep 24, 2021

What changes were proposed in this pull request?
General updates and fixes to the new measures added as part of GRIFFIN-358

Key changes:

  • Scapegoat code analysis and other minor changes to pom.xml
  • Handling of corner cases in measures
  • Better exception handling and logging for measures
  • Minor Updates to documentation and tests

Does this PR introduce any user-facing change?
Yes. Expression for completeness measure checks for complete data.

How was this patch tested?
Unit Tests

@chitralverma
Copy link
Contributor Author

@wankunde @guoyuepeng Can you please review this. thanks

@guoyuepeng
Copy link
Contributor

LGTM.

@whhe whhe merged commit ecb4d2b into apache:master Oct 4, 2021
@chitralverma chitralverma deleted the measure-enhancements branch October 5, 2021 04:50
@chitralverma chitralverma restored the measure-enhancements branch October 15, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants