Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.9] Typecast results before use in profile_tasks callback #69665

Merged
merged 1 commit into from
Jun 17, 2020
Merged

[2.9] Typecast results before use in profile_tasks callback #69665

merged 1 commit into from
Jun 17, 2020

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented May 22, 2020 •
edited by relrod
Loading

SUMMARY

Backport of ansible-collections/ansible.posix#26

If user specifies sort_order to none, results are not converted to list.
This fix force this typecasting before using the results.

Fixes: #69563

Signed-off-by: Abhijeet Kasurde [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/69563_profile_tasks.yml
lib/ansible/plugins/callback/profile_tasks.py

@Akasurde
[2.9] Typecast results before use in profile_tasks callback
ae8f816 
If user specifies sort_order to none, results are not converted to list.
This fix force this typecasting before using the results.

Fixes: ansible#69563

Signed-off-by: Abhijeet Kasurde <[email protected]>
@Akasurde Akasurde mentioned this pull request May 22, 2020
Closed
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. collection Related to Ansible Collections work collection:ansible.posix core_review In order to be merged, this PR must follow the core review workflow. has_issue needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 22, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 3, 2020
@nitzmahone nitzmahone merged commit f6829b3 into ansible:stable-2.9 Jun 17, 2020
needs_triage Needs a first human triage before being processed. label Jun 17, 2020
@ansible ansible locked and limited conversation to collaborators Jul 15, 2020
@Akasurde Akasurde deleted the backport/2.9/69563 branch February 8, 2021 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@relrod relrod relrod approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. collection:ansible.posix collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. has_issue stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Akasurde @relrod @ansibot @nitzmahone