Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async output with adhoc callbacks #59935

Merged
ansible:devel from
Aug 5, 2019
Merged

Fix async output with adhoc callbacks #59935

ansible:devel from
Aug 5, 2019

Conversation

sivel
Copy link
Member

SUMMARY

Fix async output with adhoc callbacks. Fixes #15988

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/callback/minimal.py
lib/ansible/plugins/callback/oneline.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 1, 2019
needs_triage Needs a first human triage before being processed. label Aug 1, 2019
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Aug 2, 2019
Copy link
Member

should you make a special case for 0 poll? in that case only way to see job status is another adhoc with async_status, which requires the job id

Copy link
Member Author

That is roughly the case that I was solving for. As right now, you just got no output. I didn't think I needed to special case that though

Copy link
Member

ah, totally misread as the opposite, that you were squelching job id

Closed
df6b8d2 into ansible:devel Aug 5, 2019
Aug 5, 2019
[stable-2.8] Fix async output with adhoc callbacks. Fixes ansible#15988…
b1286c7 
… (ansible#59935)

(cherry picked from commit df6b8d2)

Co-authored-by: Matt Martz <[email protected]>
abadger pushed a commit that referenced this pull request Aug 7, 2019
@abadger
[stable-2.8] Fix async output with adhoc callbacks. Fixes #15988 (#59935
978dd9f 
)

(cherry picked from commit df6b8d2)

Co-authored-by: Matt Martz <[email protected]>
@ansible ansible locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ansible -B n -P 0 does not return job_id
3 participants
@ansibot