parse botocore.endpoint logs into a list of AWS actions #49312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-hertel
commented
Nov 29, 2018
|
Hi @s-hertel, thank you for submitting this pull-request! |
|
The test The test |
|
The test The test |
mattclay
requested changes
Jan 15, 2019
| def exit_json(self, *args, **kwargs): | ||
| if self.params.get('debug_botocore_endpoint_logs'): | ||
| kwargs['resource_actions'] = self._get_resource_action_list() |
There was a problem hiding this comment.
Refactor these two lines into a function and call it from the exit_json, fail_json and fail_json_aws.
Maybe just move the logic into _get_resource_action_list and rename it.
There was a problem hiding this comment.
I refactored but didn't move the logic into _get_resource_action_listbecause it was intended to collect unique actions an individual task uses. Not strictly necessary for collecting actions a given playbook uses, but I thought having the finer grain of control had merit.
46bfef9 to
0a7e277
Compare
s-hertel
commented
Mar 1, 2019
| @@ -11,6 +11,7 @@ | |||
| - include: ./credential_tests.yml | |||
| - module_defaults: | |||
| group/aws: | |||
| debug_botocore_endpoint_logs: True | |||
There was a problem hiding this comment.
Once #51149 is merged I'll be able to remove this. Right now any tests setting module_defaults for group/aws (such as this one) overwrite the setting from the test runner.
mattclay
approved these changes
Mar 1, 2019
Ensure AWS tests inherit environment Remove AWS CLI in aws_rds inventory tests and use the module
|
cc @Java1Guy @Shaps @akazakov @ryansb @ryansydnor @willthames @wimnat @yaakov-github |
|
bot_status |
mattclay
approved these changes
Mar 6, 2019
minimize and clarify revise testing procedures moves troubleshooting into its own section this is cleaner bullets for the two choices make requirements clearer
|
!needs_revision |
mattclay
approved these changes
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to parse botocore.endpoint logs for the AWS actions performed during a task
Add a callback to consolidate all AWS actions used by modules
Allow integration tests to output AWS actions
Added some docs to help contributors help with the needs_ci_update queue
SUMMARY
This helps remove some friction when determining the minimum permissions needed for integration tests, as well as being a step in the direction of being able to document #22552
Please bikeshed names.
ISSUE TYPE
COMPONENT NAME