TargetID: Make ttt_idenfity_body_woconfirm replicated; move and clean up additional ConVars surrounding corpses/ragdolls
#1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…client can use it
…ia the ConVar object for consistency with the other globals in the hook
TimGoll
reviewed
Dec 6, 2024
Histalek
reviewed
Dec 6, 2024
ttt_idenfity_body_woconfirm and ttt2_confirm_teamttt_idenfity_body_woconfirm replicated; move and clean up additional ConVars surrounding corpses/ragdolls
|
I've updated the title and description of the PR to more accurately describe its new goal(s). I'll also quickly update the changelog entry as well, for good measure. |
TimGoll
approved these changes
Dec 9, 2024
Histalek
pushed a commit
that referenced
this pull request
Dec 10, 2024
…an up additional ConVars surrounding corpses/ragdolls (#1692) In #1684, `targetid.HUDDrawTargetIDRagdolls` was updated to check if the `ttt_idenfity_body_woconfirm` ConVar was enabled to determine what hint gets displayed. Problem is, this ConVar only exists on the server, and the TargetID library is entirely clientside. This resulted in Lua errors being thrown on every frame the function was called and managed to reach that check. This PR adds an additional table to the `CORPSE` namespace for the purpose of storing ConVar objects related to corpses and bodysearching. The following `CreateConVar` calls have been moved from `sv_main`: - `ttt_idenfity_body_woconfirm` (to `sh_corpse`, with `FCVAR_REPLICATED` added) - `ttt2_confirm_team` (to `sv_corpse`) - `ttt2_confirm_killlist` (to `sv_corpse`) I've also moved the `CreateConVar` calls for `ttt_announce_body_found` and `ttt_ragdoll_collide` into the new table for consistency, and so scripts for other parts of the gamemode can access the ConVar objects directly without having to store their own separate copies (or calling `GetConVar` repeatedly). I've also already adjusted all existing checks for these ConVars across the gamemode accordingly. The changelog entry is worded the way it is because I just can't think of any other way to describe the results of the changes without going into a level of detail that'd be unnecessary for an end-user, but still useful information for addon developers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1684,
targetid.HUDDrawTargetIDRagdollswas updated to check if thettt_idenfity_body_woconfirmConVar was enabled to determine what hint gets displayed.Problem is, this ConVar only exists on the server, and the TargetID library is entirely clientside. This resulted in Lua errors being thrown on every frame the function was called and managed to reach that check.
This PR adds a GlobalBool and ChangeCallback forttt_idenfity_body_woconfirm, and updates the check to use it instead of a nonexistent ConVar object. It also adds a ChangeCallback forttt2_confirm_team, and changes its initialSetGlobalcall to grab its name from its ConVar object to be consistent with the other GlobalVars inSyncGlobals.This PR adds an additional table to the
CORPSEnamespace for the purpose of storing ConVar objects related to corpses and bodysearching. The followingCreateConVarcalls have been moved fromsv_main:ttt_idenfity_body_woconfirm(tosh_corpse, withFCVAR_REPLICATEDadded)ttt2_confirm_team(tosv_corpse)ttt2_confirm_killlist(tosv_corpse)I've also moved the
CreateConVarcalls forttt_announce_body_foundandttt_ragdoll_collideinto the new table for consistency, and so scripts for other parts of the gamemode can access the ConVar objects directly without having to store their own separate copies (or callingGetConVarrepeatedly). I've also already adjusted all existing checks for these ConVars across the gamemode accordingly.The changelog entry is worded the way it is because I just can't think of any other way to describe the results of the changes without going into a level of detail that'd be unnecessary for an end-user, but still useful information for addon developers.