Core member variables / static types #11262
Comments
|
see more in PR #11231 |
|
Hey I am Interested in contributing this issue, How to get started ? |
|
Hi @Anubhab2003, Thank you for your interest in the Submitty open source project! We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions. We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request. NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue. |
|
@williamschen23 is this issue still open? |
|
Hi @Flying-Pegasus, Thank you for your interest in the Submitty open source project! We encourage you to join our Zulip server to discuss new features requests, bug reports, and technical implementation questions. We welcome contributions from new developers! Please read our documentation on how to get started with Submitty, specifically our pages on setting up your development environment and making a pull request. NOTE: We do not use the Github issue 'assign' feature for first time prospective contributors. You do not need to be assigned to an issue to create a pull request that will be reviewed by our team and then merged if it appropriately resolves the issue. |
Describe the bug
We do not have a method that gets the userid, so we should remove it in Core.php. We are using getUser()->getId() instead. In addition, we should verify/refactor some of the the static types in core. They are not correct with what they should be
Expected behavior
We should not have member variables where we do not use it for anything.
The text was updated successfully, but these errors were encountered: