Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DeckMTP plugin #189

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Add DeckMTP plugin #189

merged 5 commits into from
Feb 2, 2023

Conversation

dafta
Copy link
Contributor

@dafta Jan 13, 2023 •
edited by TrainDoctor
Loading

DeckMTP

This plugin adds MTP functionality to the Deck, allowing file transfer to other PC's, phones, and Steam Decks via USB.
However, in order for the plugin to work, DRD needs to be enabled in BIOS to allow gadget mode.

Checklist:

Developer Checklist

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin Checklist

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or alternatively provides more/alternative functionality to a similar plugin already on the store.

Plugin Backend Checklist

  • Yes: I am using a custom backend other than Python.
  • Yes: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Testing

  • Tested on SteamOS Stable Update Channel.
  • Tested on SteamOS Beta Update Channel.
  • Tested on SteamOS Preview Update Channel.

@TrainDoctor TrainDoctor requested review from a team January 15, 2023 19:04
TrainDoctor
TrainDoctor requested changes Jan 17, 2023
View reviewed changes
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include either the license of your choosing or replace "Hypothetical Decky Plugin Developer" with your own name/preferred alias. Thanks.

@TrainDoctor TrainDoctor self-requested a review January 17, 2023 20:34
@TrainDoctor
Copy link
Member

@dafta please make necessary adjustments to your makefile so CI may complete.

@EMERALD0874
Copy link
Member

Closing this PR since the creator is non-responsive. Please reopen this PR once you have made the requested changes.

Copy link
Contributor Author

Sorry, I was away for a while due to moving issues, internet, and having to go through the process of RMAing my Steam Deck, so I didn't notice the original build error. I have fixed it now.

@EMERALD0874 EMERALD0874 reopened this Jan 30, 2023
nabel0
nabel0 suggested changes Jan 31, 2023
View reviewed changes
Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just installed the new build. Changed USB settings in bios to "DRD" and rebooted.
But you plugin still wont let me "Enable MTP" and says "DRD is disabled..........."
But it IS enabled fro sure..I double checked in the bios.

Copy link
Contributor Author

I checked again with the plugin built by the CI, and it works on my end. I'm using the 1.0.0-eb5ea9c version of the build.

Maybe try disabling DRD, rebooting, and enabling it again. If it was on by default on your Deck, that's because of a BIOS update which seemingly enabled it but left it disabled and you had to reenable it yourself.

@nabel0
Copy link

nabel0 commented Jan 31, 2023

I checked again with the plugin built by the CI, and it works on my end. I'm using the 1.0.0-eb5ea9c version of the build.

Maybe try disabling DRD, rebooting, and enabling it again. If it was on by default on your Deck, that's because of a BIOS update which seemingly enabled it but left it disabled and you had to reenable it yourself.

doesent work
i'll disabled it..rebooted
and then i reenebled DRD again
Plugin still says it's not enabled in bios
im on bios F7A0110

nabel0
nabel0 approved these changes Feb 2, 2023
View reviewed changes
Copy link

@nabel0 nabel0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now.
Tested under steamos stable, beta and preview

TrainDoctor
TrainDoctor approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for production.

@TrainDoctor TrainDoctor merged commit c07c3a8 into SteamDeckHomebrew:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabel0 nabel0 nabel0 approved these changes

@TrainDoctor TrainDoctor TrainDoctor approved these changes

Assignees

dafta

Labels
plugin-addition
Projects
SDH Tracker
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TrainDoctor @EMERALD0874 @nabel0