include parse mode to partial cache key #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5225fae to
15464f2
Compare
15464f2 to
dd7bbf2
Compare
samdoiron
approved these changes
Jun 26, 2023
gmalette
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to solve?
When a
PartialCachegets created, it is caching theTemplateby its name and without the used parse mode.# from templates/index.liquid {% render "snippet" %} # parse the template in Lax mode # from sections/product.liquid {% render "snippet" %} # loads the previously parsed template that is parsed in Lax mode. (this should be using strict mode)How are you solving this?
Add the
ParseContext#error_modevalue to thePartialCache's cache key to add more context.