[Liquid reference docs] Adding more content to divided_by filter #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding more content to divided_by filter, by detailing the behaviour of how different results are generated by different types of divisors.
shainaraskas
approved these changes
Jan 6, 2023
There was a problem hiding this comment.
Looks lovely!
I'd consider actually breaking this into an example so you can demonstrate the different impacts on rounding, like the example in the open source docs. Alternatively, you can edit the current example so you can demo the rounding behavior, e.g.:
| @@ -757,7 +757,7 @@ def times(input, operand) | |||
| # @liquid_type filter | |||
| # @liquid_category math | |||
| # @liquid_summary | |||
| # Divides a number by a given number. | |||
| # Divides a number by a given number. The `divided_by` filter produces a result of the same type as the divisor. This means if you divide by an integer, the result will be an integer, and if you divide by a float, the result will be a float. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing feedback from https://github.com/Shopify/shopify-dev/issues/25953
This PR is adding more content to the
divided_byfilter description (on this page of shopify.dev) by detailing the behaviour of how different results are generated by different types of divisors.Before:
After: