Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partials, error_mode and render_errors options to assert_template_result #1614

Merged
merged 5 commits into from
Sep 7, 2022

Conversation

dylanahsmith
Copy link
Contributor

Follow-up to #1611

There were tests that couldn't be converted with the current assert_template_result & assert_match_syntax_error interface, since they require additional options to be supported. For instance, there is a need to specify the file system, error mode and to render liquid errors. Once that is done, more integration tests can be decoupled from the library API.

The partials, error_mode and render_errors options added by this PR correspond that stated need. I've also changed a few tests to actually use those options to exercise the code paths for the new options.

@dylanahsmith dylanahsmith merged commit 8adbbfe into master Sep 7, 2022
@dylanahsmith dylanahsmith deleted the extend-assert-tempate-result branch September 7, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants