Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharne/rsync #316

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Sharne/rsync #316

wants to merge 31 commits into from

Conversation

harneshalaka
Copy link
Contributor

Description

Created new rsync Smartdoc

Are there any relevant issues/feature requests?

Is this (based on) existing content?

  • old xml:id...
  • old URL...

Copy link
Contributor

@taroth21 taroth21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @harneshalaka ! For my remarks, please see the annotated PDF that I sent to you.

Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shalaka, please see my suggestions for this article. Please note that I haven't corrected all the prompts, so please check that all screens have user or sudo prompts as needed. Thanks!

harneshalaka and others added 4 commits February 19, 2025 12:57
@harneshalaka
Copy link
Contributor Author

Fixed feedback from @taroth21 and @dariavladykina .

Copy link
Contributor

@dariavladykina dariavladykina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, LGTM, just a minor nit found. Thanks!

@harneshalaka
Copy link
Contributor Author

@dariavladykina Done! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants