Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hospital to display more one name #108

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

okothkongo
Copy link
Contributor

@okothkongo okothkongo commented Mar 26, 2019

Fixes issue number

fixes <#108>

  • More one than hospital names are displayed to avoid confusion in case of similar names

Screenshots

Mobile view

mobile

Attach screenshot of changes as they appear on a small screen

Desktop view

desktop

GIF

hospital

Reviews

  • I have formated by code as expected
    We have a handy tool that helps you check if your elixir code is well formatted. If the tool passes on your local build
    then it will definitly pass our linting checks online

  • I have filled in all the required information above

  • I have marked my work as ready for review

@sigu sigu added the review label Mar 26, 2019
Copy link
Member

@sigu sigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such changes needs test to confirm the issue is properly solved and will not occur again

GettyOrawo
GettyOrawo previously approved these changes Apr 3, 2019
@GettyOrawo GettyOrawo dismissed their stale review April 3, 2019 11:54

tests are not present

Copy link
Member

@sigu sigu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants