-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPC 0022 Metaprogramming API #25
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
7da5fd2
Initial writings
leonerd 5487207
Various small adjustments and rewordings; added new Open Issues points
leonerd 53cda48
s/RFC/PPC/ in new doc
leonerd 2a79dcf
Lots of rewriting in places; general updates
leonerd 4a274b9
Add further thoughts about whether the glob shapes should be supported
leonerd 4b92806
Add an optional $ref parameter to $metaglob->add_scalar et.al.
leonerd c10ed8b
No need for separate get_variable / get_subroutine; just have a singl…
leonerd 9904e35
Make globs an inherent part of the API shape, not optionally
leonerd 680dcc5
Fix type of coderef's sigil
leonerd 28aefdf
Also permit a GLOB ref to ::for_reference
leonerd 31cd9f9
Escape the asterisk when quoted as the glob sigil, to avoid confusing…
leonerd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
No need for separate get_variable / get_subroutine; just have a singl…
…e for_reference()
- Loading branch information
commit c10ed8b59849a63da3fad10982b2f689ff0fb5ba
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You allow get_symbol to return a GLOB, but don't allow a globref to be passed in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahyes; might as well allow GLOBrefs too. Fixed in 387d25b