Minor changes to stop Java 8 erroring out #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts java.surefire.options and javadoc.options into profiles for JDK 1.7 and JDK 1.8+ so MaxPermSize can be ommited on newer JDKs It also adds a javadoc.opts parameter so -Xdoclint:none can be passed. This allows me to build OpenAM with the latest Java in Jenkins Finally I put pom.xml through xmllint --format
|
I can also send the change without the xmlline --format if you'd prefer |
|
can you check core.autocrlf ? In Linux/OSX This will fix any CRLF to LF when you commit. In Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This puts java.surefire.options and javadoc.options into profiles for
JDK 1.7 and JDK 1.8+ so MaxPermSize can be ommited on newer JDKs
It also adds a javadoc.opts parameter so -Xdoclint:none can be passed.
This allows me to build OpenAM with the latest Java in Jenkins
Finally I put pom.xml through xmllint --format