Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 realm config - updating 'scopes supported' requires a restart #790

Closed
lscorcia opened this issue Sep 17, 2024 · 1 comment
Closed

OAuth2 realm config - updating 'scopes supported' requires a restart #790

lscorcia opened this issue Sep 17, 2024 · 1 comment
Assignees
@vharseko

Comments

@lscorcia
Copy link
Contributor

Describe the bug
Hi, very small issue here. When editing the "scopes supported" field in the OAuth2 realm config, a server restart is required to make sure the scopes are updated in the metadata endpoint. It should be possible to update those at runtime.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Services > OAuth2 Provider
  2. Click on Supported Scopes, add a new scope
  3. Visit the metadata endpoint https://yourhost/openam/oauth2/realms/root/.well-known/openid-configuration
  4. See the new scope is missing.
  5. Restart the webapp
  6. Visit the metadata endpoint, see that the new scope is now present.

Expected behavior
The new scope should be immediately visible.

Screenshots
immagine

Additional context
It seems that the issue was already fixed in the other fork openam-jp: https://github.com/openam-jp/openam/pull/155/files .
The fix should be applicable to this project too by applying the same change here:

OpenAM/openam-oauth2/src/main/java/org/forgerock/oauth2/core/RealmOAuth2ProviderSettings.java

Lines 1036 to 1038 in 4835723

jwks.clear();
loginUrlTemplate = null;
}

@vharseko vharseko self-assigned this Sep 18, 2024
vharseko pushed a commit to vharseko/OpenAM that referenced this issue Sep 19, 2024
@kurotsu @vharseko
[OpenIdentityPlatform#790] FIX OAuth2 realm config - updating 'scopes…
8901529 
… supported' requires a restart
vharseko added a commit that referenced this issue Sep 19, 2024
@vharseko @kurotsu
[#790] FIX OAuth2 realm config - updating 'scopes supported' requires…
00ea0a0 
… a restart (#791)

Co-authored-by: Kurotsu Shogo <[email protected]>
@vharseko
Copy link
Member

please check artifacts from https://github.com/OpenIdentityPlatform/OpenAM/actions/runs/10936877974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vharseko vharseko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vharseko @lscorcia