Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Added level domain protection for normality and permbu methods. #166

Merged
merged 3 commits into from
Jan 23, 2023

Conversation

kdgutier
Copy link
Collaborator

Added a domain protection for the level list that indetermines when dealing with Normality assumptions behind the normality and permbu probabilistic reconciliation methods.

Their prediction intervals become unbounded when sending level=0.
Updated the docstring accordingly.

@kdgutier kdgutier added the bug label Jan 23, 2023
@kdgutier kdgutier requested a review from cchallu January 23, 2023 16:44
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kdgutier kdgutier requested review from AzulGarza and removed request for cchallu January 23, 2023 16:57
@kdgutier kdgutier merged commit 2eadc28 into main Jan 23, 2023
@kdgutier kdgutier deleted the level_domain_protection branch January 23, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERMBU/Normality probabilistic reconciliation fail with level=0 prediction interval
2 participants