Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Docs source links #107

Merged
merged 1 commit into from
Oct 30, 2022
Merged

[FIX] Docs source links #107

merged 1 commit into from
Oct 30, 2022

Conversation

AzulGarza
Copy link
Member

Fixes #72

@AzulGarza AzulGarza linked an issue Oct 29, 2022 that may be closed by this pull request
Source code links in documentation not working #72
Closed
mergenthaler
mergenthaler approved these changes Oct 29, 2022
View reviewed changes
Copy link
Member

@mergenthaler mergenthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I also noticed that the "Report an Issue" functionality on the documentation is not working. I think it links to a page that does not exist due to the templates that we have.

@AzulGarza
Copy link
Member Author

Great! I also noticed that the "Report an Issue" functionality on the documentation is not working. I think it links to a page that does not exist due to the templates that we have.

Nice catch! It looks like it was a general problem for all the links in the documentation because the base url was wrong. I tested it locally, and the fix solved that problem as well.🙌

@kdgutier kdgutier merged commit b52eeb3 into main Oct 30, 2022
@kdgutier kdgutier deleted the fix/72-source-code-links-in-documentation-not-working branch October 30, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergenthaler mergenthaler mergenthaler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source code links in documentation not working
3 participants
@AzulGarza @mergenthaler @kdgutier