minikube 1.5.0 (new formula) #45603
Closed
minikube 1.5.0 (new formula) #45603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidd6
approved these changes
Oct 20, 2019
|
As a minikube maintainer, I endorse this. We should probably retire the cask once this is done. Related: kubernetes/minikube#2141 NOTE: We'll need to update the minikube release automation to update this formula instead of the cask. |
|
Thanks @commitay for your contribution to Homebrew! 🎉 🥇 Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!! |
fnichol
added a commit
to fnichol/workstation
that referenced
this pull request
Nov 2, 2019
References: Homebrew/homebrew-cask#71160 References: Homebrew/homebrew-core#45603 Signed-off-by: Fletcher Nichol <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?This formula has been attempted a couple of times before: #2417, #12189, #27468
The previous problems (docker was needed for macOS builds, running
go getfor build deps) have been resolved.minikubealready exists within Homebrew as a linuxbrew only formula and a cask.