Python: Make dependency dnspython optional #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build minestat 1.0.0.225 completed (commit 8b1480222a by @mindsolve) |
|
✅ Build minestat 1.0.0.227 completed (commit e2b76119e7 by @ldilley) |
|
✅ Build minestat 1.0.0.228 completed (commit e5108c666c by @ldilley) |
|
✅ Build minestat 1.0.0.229 completed (commit 145139f603 by @ldilley) |
ldilley
approved these changes
Feb 4, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
dnspythonoptional, if SRV resolution is not explicitly enabledresolve_srvto classThis is an additon to the PR #152 by @Sch8ill. Would you mind having a look at this PR and testing it? Thank you!