This repository has been archived by the owner on May 20, 2021. It is now read-only.
Async request fix and other minor changes #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async make_request now accepts arguments of type List[str]
|
Thank you |
Detrous
added a commit
that referenced
this pull request
Jan 27, 2020
* Corrected typo in units (#37) * Added object representation (#39) * Unused imports (#40) * isort * linters ci * API return objects are now iterable (#38) * fix README * Async request fix and other minor changes (#41) * Corrected typo in units * Unused imports * API return objects are now iterable * Added object representation * Added darksky__unavailable flag. Not sure about the actual type (bool?) See https://darksky.net/dev/docs#flags for more details * Simplified camelCase utility function * Patched async request yarl type error (List[str]) async make_request now accepts arguments of type List[str] * Fix requirements & style * Disabled docstring linter rules Co-authored-by: Vysybyl <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
You might want to integrate these changes too.
Sorry for the messy GIT history.
Have a nice day!
Cheers,