-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: external_deps, use CMake when packages do, update versions #1433
base: master
Are you sure you want to change the base?
Conversation
Telling Opus to not assume more than SSE2 fixed that. |
So, the MinGW GLEW and MSVC Vorbis errors are the only ones. |
So the Vorbis build error is actually a bug:
I added a workaround. |
I don't get why I get that GLEW build error with MinGW, the build function has not been modified, and the version has not been updated. |
Also the code is the same for both |
So, I don't know what happened, now I don't reproduce the MinGW GLEW error… Maybe I gorgot to prune the prefix folder and some stray files messed-up… |
Ah, I now see something: I reproduce the bug with MinGW from Ubuntu 24.04 Noble, not with MinGW from Debian 10 Buster. So, since we produce release builds with Debian Buster, it's not a big problem, but it should be fixed for the future… |
What's the purpose of migrating things to build with CMake? |
03961c7
to
c537fe9
Compare
So with this a static build for linux-amd64 completes and runs. |
Huh? It worked before, so I have a hard time believing that is suddenly necessary to change the build system of 8 packages. |
I never said this is a response to “What's the purpose of migrating things to build with CMake?”, I'm just reporting the status of me testing that branch. I said in first post:
So now I'm running those tests. |
What's the motivation behind this change? |
Purposes:
When using configure it is hard to compare the list of already used options with the new options, one has to read configure's whole output and compare with what's currently used. On the contrary with cmake, one just runs the existing command, then go to the build dir and run ccmake, and see what's enabled and should not, and report the difference to the build script. |
ac1c6e1
to
5653846
Compare
5860e20
to
c73312c
Compare
windows-amd64-mingw and windows-i686-mingw engine both build and run. |
For some reasons libpng now provides |
2773253
to
2dd223e
Compare
linux-i686-default and macos-amd64-default engine both build and run. |
This is WIP, current external_deps build status:
I haven't tested if the engine builds and runs properly with those.WIPWhat this PR does:
CMakeLists.txt
file