Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Match/Page Counter(Addresses #204) #325

Merged
merged 8 commits into from
Dec 27, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions client/common/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ usage(FILE *out, const char *name)
" -K, --no-keyboard ignore keyboard events.\n"
" --binding use alternative key bindings. Available options: vim\n"
" --scrollbar display scrollbar. (none (default), always, autohide)\n"
" --counter display a matched/total items counter. (none (default), always)\n"
" --accept-single immediately return if there is only one item.\n"
" --ifne only display menu if there are items.\n"
" --fork always fork. (bemenu-run)\n"
Expand Down Expand Up @@ -271,6 +272,7 @@ do_getopt(struct client *client, int *argc, char **argv[])
{ "prefix", required_argument, 0, 'P' },
{ "password", no_argument, 0, 'x' },
{ "scrollbar", required_argument, 0, 0x100 },
{ "counter", required_argument, 0, 0x10a },
{ "accept-single",no_argument, 0, 0x11a },
{ "ifne", no_argument, 0, 0x117 },
{ "fork", no_argument, 0, 0x118 },
Expand Down Expand Up @@ -362,6 +364,9 @@ do_getopt(struct client *client, int *argc, char **argv[])
case 0x100:
client->scrollbar = (!strcmp(optarg, "none") ? BM_SCROLLBAR_NONE : (!strcmp(optarg, "always") ? BM_SCROLLBAR_ALWAYS : (!strcmp(optarg, "autohide") ? BM_SCROLLBAR_AUTOHIDE : BM_SCROLLBAR_NONE)));
break;
case 0x10a:
client->counter = (!strcmp(optarg, "always"));
break;
case 0x11a:
client->accept_single = true;
break;
Expand Down Expand Up @@ -543,6 +548,7 @@ menu_with_options(struct client *client)
bm_menu_set_monitor(menu, client->monitor);
bm_menu_set_monitor_name(menu, client->monitor_name);
bm_menu_set_scrollbar(menu, client->scrollbar);
bm_menu_set_counter(menu, client->counter);
bm_menu_set_panel_overlap(menu, !client->no_overlap);
bm_menu_set_spacing(menu, !client->no_spacing);
bm_menu_set_password(menu, client->password);
Expand Down
1 change: 1 addition & 0 deletions client/common/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ struct client {
bool center;
bool grab;
bool wrap;
bool counter;
bool accept_single;
bool ifne;
bool no_overlap;
Expand Down
19 changes: 18 additions & 1 deletion lib/bemenu.h
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,6 @@ BM_PUBLIC void bm_menu_set_border_radius(struct bm_menu* menu, uint32_t border_r

BM_PUBLIC uint32_t bm_menu_get_border_radius(struct bm_menu* menu);


/**
* Set a hexadecimal color for element.
*
Expand Down Expand Up @@ -698,6 +697,24 @@ BM_PUBLIC void bm_menu_set_scrollbar(struct bm_menu *menu, enum bm_scrollbar_mod
*/
BM_PUBLIC enum bm_scrollbar_mode bm_menu_get_scrollbar(struct bm_menu *menu);

/**
* Set the counter display mode.
*
* @param menu bm_menu to set the counter for.
* @param display mode to be set.
*/

BM_PUBLIC void bm_menu_set_counter(struct bm_menu *menu, bool mode);

/**
* Get the counter display mode.
*
* @param menu bm_menu to get the counter from.
* @return current counter display mode
*/

BM_PUBLIC bool bm_menu_get_counter(struct bm_menu *menu);

/**
* Set the vertical alignment of the bar.
*
Expand Down
5 changes: 5 additions & 0 deletions lib/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,11 @@ struct bm_menu {
*/
enum bm_scrollbar_mode scrollbar;

/**
* Current counter display mode.
*/
bool counter;

/**
* Should selection be wrapped?
*/
Expand Down
13 changes: 12 additions & 1 deletion lib/menu.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,18 @@ bm_menu_get_scrollbar(struct bm_menu *menu)
return menu->scrollbar;
}

void
bm_menu_set_counter(struct bm_menu *menu, bool mode)
{
menu->counter = mode;
}

bool
bm_menu_get_counter(struct bm_menu *menu)
{
return menu->counter;
}

void
bm_menu_set_align(struct bm_menu *menu, enum bm_align align)
{
Expand Down Expand Up @@ -778,7 +790,6 @@ bm_menu_filter(struct bm_menu *menu)
size_t oldLen = strlen(menu->old_filter);
addition = (oldLen < len && !memcmp(menu->old_filter, menu->filter, oldLen));
}

if (menu->old_filter && addition && menu->filtered.count <= 0)
return;

Expand Down
18 changes: 15 additions & 3 deletions lib/renderers/cairo_renderer.h
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ bm_cairo_paint(struct cairo *cairo, uint32_t width, uint32_t max_height, const s

uint32_t border_radius = menu->border_radius;

uint32_t total_item_count = menu->items.count;
uint32_t filtered_item_count = (menu->filter ? menu->filtered.count : total_item_count);

cairo_set_source_rgba(cairo->cr, 0, 0, 0, 0);
cairo_rectangle(cairo->cr, 0, 0, width, height);

Expand Down Expand Up @@ -469,15 +472,24 @@ bm_cairo_paint(struct cairo *cairo, uint32_t width, uint32_t max_height, const s
out_result->displayed += (cl < width);
out_result->height = fmax(out_result->height, result.height);
}

bm_cairo_color_from_menu_color(menu, BM_COLOR_FILTER_FG, &paint.fg);
bm_cairo_color_from_menu_color(menu, BM_COLOR_FILTER_BG, &paint.bg);
if (menu->wrap || menu->index + 1 < count) {
bm_cairo_color_from_menu_color(menu, BM_COLOR_FILTER_FG, &paint.fg);
bm_cairo_color_from_menu_color(menu, BM_COLOR_FILTER_BG, &paint.bg);
bm_pango_get_text_extents(cairo, &paint, &result, ">");
paint.pos = (struct pos){ width/cairo->scale - result.x_advance - 2, vpadding + border_size };
paint.box = (struct box){ 1, 2, vpadding, -vpadding, 0, height };
bm_cairo_draw_line(cairo, &paint, &result, ">");
}

}

if (menu->counter) {
char counter[128];
snprintf(counter, sizeof(counter), "[%u/%u]", filtered_item_count, total_item_count);
bm_pango_get_text_extents(cairo, &paint, &result, "%s", counter);
paint.pos = (struct pos){ width/cairo->scale - result.x_advance - 10, vpadding + border_size };
paint.box = (struct box){ 1, 2, vpadding, -vpadding, 0, height };
bm_cairo_draw_line(cairo, &paint, &result, "%s", counter);
}

// Draw borders
Expand Down