Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --filter #322

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Fix --filter #322

merged 3 commits into from
Dec 16, 2022

Conversation

robertgzr
Copy link
Contributor

@robertgzr robertgzr commented Dec 15, 2022

  • wayland: don't chomp dirty state when window is pending
  • common: actually parse -F using getopt
  • Apply initial filter before evaluating accept-single

Running `printf "foo\nbar\n" | bemenu --filter foo` no results would
show up until something set the dirty state (like interacting with the
keyboard, e.g. deleting a character).

This would only happen on wayland, due to the render implementation not
considering the dirty state when the window was not yet created and then
just overwriting `menu->dirty` with `false`.

Signed-off-by: Robert Günzler <[email protected]>
This lets us select fully non-interactive if we have a perfect match

Signed-off-by: Robert Günzler <[email protected]>
@Cloudef Cloudef merged commit 0a44fb6 into Cloudef:master Dec 16, 2022
@Cloudef
Copy link
Owner

Cloudef commented Dec 16, 2022

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants