Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Massive amount of CPSEO settings appear in Post's Custom Metadata #69

Open
elosha opened this issue Apr 6, 2020 · 1 comment
Open

Massive amount of CPSEO settings appear in Post's Custom Metadata #69

elosha opened this issue Apr 6, 2020 · 1 comment
Assignees
@timbocode
Labels
Enhancement Improvement to an existing feature

Comments

@elosha
Copy link

elosha commented Apr 6, 2020

I'm running CP 1.1.2 (German locale) and just updated CP SEO to 1.0.0-beta.3.

I've noticed huge amounts of CPSEO Custom Metadata appended to my Posts. See below for the disruptive impact this has.

These seem to be CPSEO internal settings. I understand that they should not appear if CPSEO is correctly working and showing its editor.

What you can't see is another effect: When I start a new post and want to add my Custom Meta field called "epaper" that I actually want and need, it has been kicked out of the dropdown containing usual Custom Meta entries.

Additionally, I would say that it makes no sense to save all of these settings with every post, at all. Especially since some seem are actually totally unrelated to the current installation (like Recipe rich snippets). You understand, I switched to CP and CPSEO to reduce bloat ;)

cpseo-bogus-custommeta
@timbocode timbocode added this to the Version 1.0.0-Beta4 milestone May 17, 2020
@timbocode timbocode self-assigned this May 17, 2020
@timbocode timbocode added the Enhancement Improvement to an existing feature label May 17, 2020
@timbocode timbocode mentioned this issue May 17, 2020
Merged
timbocode added a commit that referenced this issue May 17, 2020
@timbocode
Hide cpseo meta key data in custom fields on post edit page (#76)
b7eee13 
Temporary workaround for #69 .
@timbocode timbocode mentioned this issue May 17, 2020
Open
@timbocode
Copy link
Contributor

Hi @elosha . Sorry again for the delay in responding.

It would appear that there are 2 or 3 issues here.

1. Classic SEO is creating unnecessary post meta data.
This is true. Unfortunately, this is a carry-over from Rank Math 1.0.33 on which Classic SEO is based. It is something I'm aware of and will be dealt with under issue 41 Remove redundant code / clean codebase but this won't be until after version 1.0 has been released.

2. cpseo meta data is being displayed in WP custom fields which is disruptive.
Also true. I've created PR #76 which prevents the cpseo data from displaying. This is a temporary workaround until #41 can be addressed.

3. Other required meta data does not display in the Custom Fields dropdown list.
Again, this is true. However, this should be resolved by #76 . It is also worth noting that the number of fields displayed in the dropdown is limited to 30 by ClassicPress / WordPress itself. This can be increased by using the postmeta_form_limit filter as described here https://developer.wordpress.org/reference/hooks/postmeta_form_limit/.

Hopefully this addresses all of the concerns you raise in this issue.

@timbocode timbocode removed this from the Version 1.0.0-Beta4 milestone May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timbocode timbocode

Labels
Enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timbocode @elosha