Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: port to gtk4 #44

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

refactor: port to gtk4 #44

wants to merge 18 commits into from

Conversation

ChildishGiant
Copy link
Owner

Currently a WIP

@ChildishGiant
Copy link
Owner Author

@ryonakano I've made some changes in this branch that clash with the PR you submitted a bit ago to fix language building. I don't really understand the arcane magic of meson so would love if you had the time to look at this. The CI build is only failing due to appstream not liking the old screenshot dimensions, locally building works fine

Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the meson things are correctly set up, just we're missing some code in the Applications class.

}


construct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the following code somewhere in the constructor of this class to show your app in the user language:

            Intl.setlocale (LocaleCategory.ALL, "");
            Intl.bindtextdomain (Constants.GETTEXT_PACKAGE, Constants.LOCALE_DIR);
            Intl.bind_textdomain_codeset (Constants.GETTEXT_PACKAGE, "UTF-8");
            Intl.textdomain (Constants.GETTEXT_PACKAGE);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants