Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename data management zone #92

Merged
merged 3 commits into from
Jan 10, 2022
Merged

Rename data management zone #92

merged 3 commits into from
Jan 10, 2022

Conversation

mboswell
Copy link
Contributor

@mboswell mboswell commented Jan 7, 2022 •
edited
Loading

Summary of the Pull Request

Rename data management zone

References

PR Checklist

  • CLA signed. If not, go over here and sign the CLA

Validation Steps Performed

@mboswell mboswell added the documentation Improvements or additions to documentation label Jan 7, 2022
@mboswell mboswell marked this pull request as ready for review January 10, 2022 08:54
@mboswell mboswell requested a review from a team as a code owner January 10, 2022 08:54
@ghost ghost added the review Review required for pull request label Jan 10, 2022
marvinbuss
marvinbuss requested changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments below and fix merge conflicts.

.vscode/settings.json Outdated Show resolved Hide resolved
@ghost ghost added needs author feedback Awaiting feedback and response from author and removed review Review required for pull request labels Jan 10, 2022
@ghost ghost added review Review required for pull request and removed needs author feedback Awaiting feedback and response from author review Review required for pull request labels Jan 10, 2022
@mboswell mboswell requested a review from marvinbuss January 10, 2022 10:16
@ghost ghost added the review Review required for pull request label Jan 10, 2022
marvinbuss
marvinbuss approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghost ghost removed the review Review required for pull request label Jan 10, 2022
@mboswell mboswell merged commit 818fb4e into main Jan 10, 2022
@mboswell mboswell deleted the mboswell/renamedmz branch January 10, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinbuss marvinbuss marvinbuss approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboswell @marvinbuss