Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lots of issues... #87

Open
mysteryx93 opened this issue Dec 12, 2021 · 6 comments
Open

Lots of issues... #87

mysteryx93 opened this issue Dec 12, 2021 · 6 comments
Assignees
@CreateLab

Comments

@mysteryx93
Copy link

I'm trying this MessageBox implementation. I'm seeing lots of issues with it.

  • EnterDefaultButton and EscDefaultButton just got implemented for default value, but that implementation is bulky and non-intuitive to use. I'd rather just pass the default button as an enumeration, and the control should know which one is the cancel button.
  • The message box has a minimize button; leaving very little space for the messagebox title
  • Focus is set to nothing by default, and "space" doesn't press the default button. Need to press Tab twice to select the button.
  • Once the button receives the focus with tab, it displays differently and not pretty; and selecting it with the mouse doesn't give the same visual effect
  • Button text is left-aligned and looks weird. I think center-aligned would be better
  • Setting styles (Unix/MacOs/Windows) on the MessageBox itself is kind of weird... it would make more sense to set that style at the application level!

Finally, I really think this (or a better implementation of this) should be part of Avalonia itself.
@mysteryx93 mysteryx93 mentioned this issue Dec 12, 2021
Closed
@CreateLab CreateLab self-assigned this Dec 12, 2021
@CreateLab
Copy link
Member

As i speak with avalonia native developers - msbox will never be a part of avaloniaui. If u wanna help - u may send some pr to improve this lib.

CreateLab pushed a commit that referenced this issue Dec 12, 2021
#87 remove styles
c2a14f1
@CreateLab
Copy link
Member

Set styles
Remove styles
Need to add style names for all

CreateLab pushed a commit that referenced this issue Dec 12, 2021
#87 add Classes to message box components
05727ea
CreateLab pushed a commit that referenced this issue Dec 12, 2021
#87 binding styles in Custom buttons
13e4d0f
@CreateLab
Copy link
Member

~~Button content alignment ~~

CreateLab pushed a commit that referenced this issue Dec 12, 2021
#87 button content aligment
8d310d9
@mysteryx93
Copy link
Author

mysteryx93 commented Dec 12, 2021 •
edited
Loading

Why do you say MessageBox would never be part of Avalonia? Why are they not interested in this?

There are discussions about its implementation here

Btw your styling option is really neat -- and I would love to be able to set that style at the application level.

@CreateLab
Copy link
Member

As we discuss with @kekekeks, some systems have no message box, some systems have just one window with popups, some systems have only one window and nobody has solution how to implement message box. This implementation support only with me and some community and has no relationships with main avalonia repo.

@robloo
Copy link

robloo commented Feb 17, 2022 •
edited
Loading

some systems have only one window and nobody has solution how to implement message box.

This is easily solvable with an overlay over the specified top-level root (window) like UWP: https://docs.microsoft.com/en-us/windows/apps/design/controls/dialogs-and-flyouts/dialogs. UWP had to solve this same problem because mobile devices were full-screen apps with no windowing system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CreateLab CreateLab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mysteryx93 @robloo @CreateLab