Chromium Code Reviews
[email protected] (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 18850005: Disable double tap zoom on mobile sites, to remove 300ms click delay (Closed)

Created:
7 years, 5 months ago by johnme
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Peter Beverloo
Visibility:
Public.

Description

Disable double tap zoom on mobile sites, to remove 300ms click delay This patch disables double tap zoom on pages that have a width=device-width or narrower viewport (indicating that this is a mobile-optimized or responsive website). Double tap zoom continues to be disabled for pages that disallow the user from zooming (even if they don't have a device-width or narrower viewport). This causes very noticeable performance benefits: links, buttons, checkboxes, etc respond within around 10ms instead of 300ms. Tested this on: http://jsbin.com/ixibol/6 Users shouldn't miss the double-tap gesture in the affected situations, as double-tap means "zoom until tapped content is legible", and in all the cases above the content was already legible (already displayed at 1 or more DIPs per CSS pixel), so double tap zoom didn't make sense and didn't do much. BUG=169642 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232245

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address klobag's comment #

Patch Set 3 : Rewrite, taking into account crrev.com/27043004 #

Total comments: 5

Patch Set 4 : Always disable, rather than enabling iff zoomed in by more than 10% #

Total comments: 3

Patch Set 5 : Fix typo #

Total comments: 4

Patch Set 6 : Addressed Ted's nits #

Patch Set 7 : Rebase #

Messages

Total messages: 25 (0 generated)
johnme
7 years, 5 months ago (2013-07-08 17:42:20 UTC) #1
johnme
7 years, 5 months ago (2013-07-08 17:42:54 UTC) #2
Rick Byers
On 2013/07/08 17:42:54, johnme wrote: I don't know the Clank Java code so I'll avoid ...
7 years, 5 months ago (2013-07-08 18:52:30 UTC) #3
aelias_OOO_until_Jul13
This seems alright. Grace, what do you think?
7 years, 5 months ago (2013-07-08 23:36:43 UTC) #4
klobag.chromium
I am fine with the direction. But do we really want to add/remove listener? https://codereview.chromium.org/18850005/diff/1/content/public/android/java/src/org/chromium/content/browser/ContentViewGestureHandler.java ...
7 years, 5 months ago (2013-07-10 18:26:21 UTC) #5
johnme
klobag wrote: > I am fine with the direction. But do we really want to ...
7 years, 5 months ago (2013-07-10 19:19:16 UTC) #6
klobag.chromium
On 2013/07/10 19:19:16, johnme wrote: > klobag wrote: > > I am fine with the ...
7 years, 5 months ago (2013-07-10 21:07:05 UTC) #7
aelias_OOO_until_Jul13
Going through old patches in my review list. Should this be closed?
7 years, 3 months ago (2013-09-09 22:43:50 UTC) #8
johnme
aelias wrote: > Going through old patches in my review list. Should this be closed? ...
7 years, 2 months ago (2013-10-22 10:45:04 UTC) #9
jdduke (slow)
https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1479 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1479: mContentViewGestureHandler.updateShouldDisableDoubleTap(disable); So the user can double-tap to zoom out, ...
7 years, 2 months ago (2013-10-22 14:15:08 UTC) #10
johnme
https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1479 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1479: mContentViewGestureHandler.updateShouldDisableDoubleTap(disable); On 2013/10/22 14:15:08, jdduke wrote: > > So ...
7 years, 2 months ago (2013-10-22 15:57:58 UTC) #11
aelias_OOO_until_Jul13
https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1477 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1477: boolean disable = (contentWidthCss <= windowWidthDp && pageScale < ...
7 years, 2 months ago (2013-10-22 23:43:26 UTC) #12
jdduke (slow)
https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java (right): https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java#newcode1477 content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:1477: boolean disable = (contentWidthCss <= windowWidthDp && pageScale < ...
7 years, 2 months ago (2013-10-22 23:57:48 UTC) #13
johnme
Removed the "pageScale < 1.1f * minScale" condition at aelias & jdduke's suggestion. https://codereview.chromium.org/18850005/diff/16001/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java File ...
7 years, 2 months ago (2013-10-23 11:46:07 UTC) #14
aelias_OOO_until_Jul13
lgtm
7 years, 2 months ago (2013-10-23 18:16:19 UTC) #15
klobag.chromium
https://codereview.chromium.org/18850005/diff/106001/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java File content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java (right): https://codereview.chromium.org/18850005/diff/106001/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java#newcode278 content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java:278: return mContentWidthCss <= windowWidthDp; is it a typo? windowWidthDip ...
7 years, 2 months ago (2013-10-23 21:02:35 UTC) #16
johnme
Fixed typo. https://codereview.chromium.org/18850005/diff/106001/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java File content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java (right): https://codereview.chromium.org/18850005/diff/106001/content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java#newcode278 content/public/android/java/src/org/chromium/content/browser/RenderCoordinates.java:278: return mContentWidthCss <= windowWidthDp; On 2013/10/23 21:02:36, ...
7 years, 2 months ago (2013-10-24 11:05:11 UTC) #17
klobag.chromium
lgtm
7 years, 2 months ago (2013-10-24 19:48:18 UTC) #18
Ted C
Can we add a test somewhere that ensures double tap is disabled for narrow pages? ...
7 years, 2 months ago (2013-10-24 19:52:43 UTC) #19
Ted C
also lgtm :-)
7 years, 2 months ago (2013-10-24 19:52:56 UTC) #20
jdduke (slow)
On 2013/10/24 19:52:56, Ted C wrote: > also lgtm :-) Are we still moving forward ...
7 years, 1 month ago (2013-10-31 01:02:16 UTC) #21
johnme
> Are we still moving forward on this? Yep, a weekend and sheriffing stint meant ...
7 years, 1 month ago (2013-10-31 19:13:12 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18850005/236001
7 years, 1 month ago (2013-10-31 20:58:56 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/[email protected]/18850005/446001
7 years, 1 month ago (2013-11-01 00:12:46 UTC) #24
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 00:35:19 UTC) #25
Message was sent while issue was closed.
Change committed as 232245

Powered by Google App Engine
This is Rietveld 408576698