I'm not familiar with J B Priestley's book of The Good Companions so I can only comment on this 1957 British musical film as a stand alone feature. I have no idea how this fared at the box office but as it was made at a time after Rock 'n' Roll had already made it's mark, I do wonder why it was considered a good idea. We never really made many good musicals compared to the might of America and this creaky effort is just another disappointment, in spite of me hoping for more. I had been tempted to watch it, seeing the name of that fine actor Eric Portman heading the cast, and indeed he is probably the best actor on board with some sharp lines and his strong personality. Sadly, the support isn't as good. This is basically a music hall scenario, made at a time long after music hall had faded away, replaced as I say by rock 'n' roll and TV, the year of release was 1957 so they should have known better. Choice of director is odd in retrospect, being J. Lee Thompson, known for his thrillers and adventure films and he did make some very good ones, including Ice Cold in Alex, Tiger Bay and The Guns of Navarone and who ended his career helming nine pictures with old Stone Face Charles Bronson, so a musical was an oddity in his career. The songs such as they are seem rather weak and Janette Scott (Thora Hird's daughter) who was just coming to maturity is sweet enough as a lead in a Debbie Reynolds sort of way, but unfortunately lacks the zest and talent of Debbie Reynolds. Lots of small character parts do add interest, not least from Joyce Grenfell, Anthony Newley, Shirley Ann Field, Melvyn Hayes and Janette Scott's mum, Thora Hird. Hugh Griffith, a fine Oscar winning actor (Ben Hur) is wasted in a weak part. Celia Johnson of Brief Encounter fame doesn't fare much better as the lady who saves the touring troupe, the Dinky Doos and changes the name to The Good Companions. Could have been better. Another film I saw recently, Harry Secombe's 'Davy', covering exactly the same material about failed touring troupes in music hall I found more satisfying.