Split, insert and join

Question

Here's I want to archive. I want to split a one-liner comma-separated and insert @domain.com then join it back as comma-separated.

The one-liner contains something like:

username1,username2,username3

and I want to be something like:

[email protected],[email protected],[email protected]

So my Perl script that I tried which doesn't not work properly:

my $var ='username1,username2,username3';
my @tkens = split /,/, $var;
my @user;
       foreach my $tken (@tkens) {
           push (@user, "$tken\@domain.com");
       }
my $to = join(',',@user);

Is there any shortcut on this in Perl and please post sample please. Thanks

Answer 1

Split, transform, stitch:

my $var ='username1,username2,username3';
print join ",", map { "$_\@domain.com" } split(",", $var);
# ==> [email protected],[email protected],[email protected]

Answer 2

You could also use a regular expression substitution:

#!/usr/bin/perl
use strict;
use warnings;

my $var = "username1,username2,username3";
# Replace every comma (and the end of the string) with a comma and @domain.com
$var =~ s/$|,/\@domain.com,/g;
# Remove extra comma after last item
chop $var;
print "$var\n";

Answer 3

You already have good answers. Here I am just telling why your script is not working. I didn't see any print or say line in your code, so not sure how you are trying to print something. No need of last line in your program. You can simply suffix @domain.com with each value, push to an array and print it with join.

#!/usr/bin/perl
use strict;
use warnings;

my $var = 'username1,username2,username3';
my @tkens = split ',', $var;
my @user;
foreach my $tken (@tkens)
{
    push @user, $tken."\@domain.com"; # `.` after `$tken` for concatenation  
}
print join(',', @user), "\n"

Output:

[email protected],[email protected],[email protected]