https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/fedora-rawhide-pr-pipeline/detail/fedora-rawhide-pr-pipeline/182/pipeline

Thanks for the PR. I'm not up to date as to how the centos ci fits into fedora. I'm happy to merge this in as long as it won't change the packaging itself.

It doesn't change the packaging. Yet the tests currently fail due to infrastructure issue. Not sure when that'll get fixed.

since this is the virtualenv package, I suggest we add METHOD=virtuelenv to every Python version.

this one is not needed. in fact, can we put virtual provides here and only list /usr/bin/virtualenv?

I'm :thumbsup: to merging once the comments are taken care of.

Thanks for the feedback. I've updated the pull request according to comments. I've also removed python 2.6 from the list as the test does not work. Seems the pip is old and cannot be upgraded:

# virtualenv --python=python2.6 venv26
Running virtualenv with interpreter /usr/bin/python2.6
New python executable in /tmp/venv26/bin/python2.6
Also creating executable in /tmp/venv26/bin/python
Installing setuptools<37, pip<10, wheel<0.30...done.
# source venv26/bin/activate
(venv26) # python -m pip install pytest
/tmp/venv26/bin/python: pip is a package and cannot be directly executed
(venv26) # pip --version
pip 9.0.3 from /tmp/venv26/lib/python2.6/site-packages (python 2.6)
(venv26) # pip install --upgrade pip
DEPRECATION: Python 2.6 is no longer supported by the Python core team, please upgrade your Python. A future version of pip will drop support for Python 2.6
Requirement already up-to-date: pip in ./venv26/lib/python2.6/site-packages
You are using pip version 9.0.3, however version 18.0 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Any hint how to get it working for 2.6 as well? The CI job has failed but this seems to be problem of the pipeline:

https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/fedora-rawhide-pr-pipeline/detail/fedora-rawhide-pr-pipeline/234/pipeline/

We are looking into it. I'll update the PR when we know more details.

where is

(venv26) # pip install --upgrade pip

coming from? I don't see that in https://src.fedoraproject.org/tests/python/blob/master/f/smoke/venv.sh

The ability to test 2.6 is important, as recently it broke without us noticing.

That was just my attempt to do the upgrade. But it fails with 2.6 and just keeps the old version. Any recommendation how to get a more fresh version of pip on the system for testing 2.6? Or any other way how to avoid the "pip is a package and cannot be directly executed" error?

Nope. Pip > 9 doesn't support Python 2.6. No updates there.

For:

 python -m pip install pytest
/tmp/venv26/bin/python: pip is a package and cannot be directly executed

We would probably need to just run:

pip install pytest

Instead.

OK, I'll adjust the test to make it working for 2.6 as well.

Thanks.

[citest]

Pipe went well, but tests failed. We need to specify gcc in the requires as well. Pull request updated accordingly.

However, there is an additional error for python 2.6 test case. Not sure what might be wrong there. When I run the test locally it works fine. Need to investigate.

Rebase this PR to have at least https://src.fedoraproject.org/rpms/python-virtualenv/c/d384e0f325e08562edcbd9981e4a5e0af03daf28?branch=master

Thanks for the hint. Rebased.
[citest]

Test execution is stuck. Investigating.
Seems to be a CentosCI openshift project issue.

The testing finished with the following error for Python 2.6:

{standard input}: Assembler messages:
{standard input}:330769: Warning: end of file not at end of a line; newline inserted
{standard input}:331620: Error: unknown pseudo-op: `.l'
gcc: fatal error: Killed signal terminated program cc1
compilation terminated.
error: command 'gcc' failed with exit status 1

Looks like killed? The whole log available here:

• https://jenkins-continuous-infra.apps.ci.centos.org/job/fedora-rawhide-pr-pipeline/269/artifact/package-tests/logs/FAIL_smoke26.log

Test cases for other Python versions successfully passed.

[citest]

It passes for me locally, yet it compiles Cython which might take ages. I've pushed: https://src.fedoraproject.org/tests/python/c/5169b862387116eeaec7442a48e936506800afb2?branch=master

[citest]

(The error might be not enough RAM to compile Cython.)

Created a pull request to define minimum resources:
https://github.com/CentOS-PaaS-SIG/ci-pipeline/pull/717

The tests now run for another hour and I see no useful output. What am i missing? How do I see the output of the testing script?

https://src.fedoraproject.org/tests/python/c/2540126bc6af6b52caf5d06a8288197d523ade10?branch=master

[citest]

Set tox false for 2.6.

[citest]

Almost there, but the CI doesn't work again :(

Yeah, there was a problem with disk space on Jenkins. Should be fixed now. We just need to wait until a new qcow2 image is created:

https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/fedora-rawhide-image-test/detail/fedora-rawhide-image-test/70/pipeline

One more [citest], please ;-)

And the story continues :) Seems we hit some kvm issue:

• https://jenkins-continuous-infra.apps.ci.centos.org/blue/organizations/jenkins/fedora-rawhide-pr-pipeline/detail/fedora-rawhide-pr-pipeline/276/pipeline

This is supposed to be a known and already fixed issue with some nodes missing kvm support. Investigating...

Hooray! Finally :)
Fedora CI success
Package tests: passed

OK. Let's rebase and then merge?

Rebased, pushed, let's see what happens ;-)

Koji build failed:

RPM build errors:
Directory not found: /builddir/build/BUILDROOT/python-virtualenv-16.0.0-5.fc30.noarch/usr/lib/python2.7/site-packages/virtualenv-*.egg-info

Oh. I know where the problem is.

Rebase now. Sorry about that.

OK, seems we had a network issue while downloading koji build:

+ koji download-task --arch=x86_64 --arch=src --arch=noarch --logs 29377027
ConnectionError: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
script returned exit code 1

One more [citest], please ;-)

This is so exciting :D

Victory! :-)

Thank You!

Thanks for the patience!

Please coordinate the rest in https://bugzilla.redhat.com/show_bug.cgi?id=1623434