HomePhabricator

Do not try to send PDF when user aborts the render
1981dc95160dUnpublished

Tags
None
Referenced Files
None
Subscribers
None

Unpublished Commit · Learn More

Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

Do not try to send PDF when user aborts the render

When user aborts the job that already started to render, it still
calls the callback() even the output is undefined. if pdf
variable is undefined we shouldn't return the output, just close
the resource. Also, because there was no output code was throing
a `Cannot read property 'length' of null"' error. This patch should
fix that

Additional changes:

  • request stats should be always counted, not only when jobs arre successful

Bug: T186748
Change-Id: I7a278304b10733424d2340113c18a809ab2da2f5

Details

Provenance
pmiazgaAuthored on Jun 26 2018, 11:57 AM
Parents
rMSCRfe538a038a80: Add fonts-noto to support printing of non-latin characters
Branches
Unknown
Tags
Unknown
ChangeId
I7a278304b10733424d2340113c18a809ab2da2f5

Event Timeline