/ˈmɪnhɑː(d)ʒ)/ means /ˈmɪnhɑːdʒ/ or /ˈmɪnhɑːʒ/. If it doesn't return two distinct iterations then it should be considered a fail.

In T313711#8104497, @dom_walden wrote:

• catnip (ˈkætⁿnɪp)
• apt (ˈæp̚t)
• peculiar (pʰə̥ˈkj̊uːliɚ)
• key (k̟ʰi)

In T322337#8406969, @Zdzislaw wrote:

@Samwilson , @dom_walden @TheresNoTime
After the change introduced here, the preview (in the vector-2022 skin) reverted to the standard font size in the main space,
but on Wikisource in the "Page" NS it made that (in the preview) unfortunately the font size is too small(!) (

@HMonroy @Samwilson I validated that Chrome, Safari, FireFox, and Edge have pop-up errors that don't mesh with the left window pane but lay over top of it in the Legacy Vector skin.

In T316913#8417978, @Reedy wrote:

Using Maryum's commit listed of e8c34df vs HEAD of writing, d6881a4 - https://github.com/wikimedia/mediawiki-libs-IPAValidator/compare/e8c34df...d6881a4 the only "code" change I see is the namespacing as part of the move to gerrit etc.

The rest is mostly packaging and the like.

Using Maryum's commit listed of e8c34df vs HEAD of writing, d6881a4 - https://github.com/wikimedia/mediawiki-libs-IPAValidator/compare/e8c34df...d6881a4 the only "code" change I see is the namespacing as part of the move to gerrit etc.

I see @Reedy left a couple of comments on the gerrit change set. Would you or @TheresNoTime be able to provide a comprehensive diff of any changes to the package since the security review @maryum posted above on 11/4/2022? And any of the administrative updates @TheresNoTime was working on above? Thanks.

Two thoughts:

1. maps are also thinking about expiry (from thanos-swift rather than ms-swift) cf T307184 ; a common approach might reduce wheel-reinvention.
2. I'm quite opposed to adding functionality to our rewrite middleware; it makes me unhappy having something non-standard in the middle of our ms swift instances (and any rewrite-based approach wouldn't work on thanos, which doesn't have the rewrite middleware).

In T319463#8415248, @MusikAnimal wrote:

When I check the "Watch proposal page" it actually watches the /Voting subpage (e.g. Wikipedia:AddMe-test/Foobar/Voting).

That test page doesn't perfectly simulate the survey. In the actual survey, the "proposal page" is the one with the discussion and all the votes, and the proposal itself is yet another subpage (once it's set up for translation). So anyway in the actual survey, you'd be watching the desired page; that is, the one you placed your vote on that also has the discussion section. I just wanted to simulate the handling of transcluded subpages which is why I put the votes on a dedicated subpage.

In T319463#8413903, @dom_walden wrote:

Also:

• Should it strip newlines in comments? (e.g. https://test.wikipedia.org/wiki/Wikipedia:AddMe-test#Voting_13)

Thanks for the swift and thorough review!

Change 859615 merged by jenkins-bot:

[integration/config@master] layout.yaml: Add doxygen-publish and phpunit-coverage for IPAValidator

https://gerrit.wikimedia.org/r/859615

Change 859615 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] layout.yaml: Add doxygen-publisha and phpunit-coverage for IPAValidator

https://gerrit.wikimedia.org/r/859615

In T320835#8404028, @dmaza wrote:

@Eevans you mentioned Swift expiry in T320675#8317876. Would it be acceptable to set X-Delete-At to something like 3 months in the future, and if the file gets used a week prior to the expiration date, use describe to reset X-Delete-At for another 3 months? (Date ranges are TBD and can be adjusted as we go)

Wouldn't this solve any potential leakage?

Here is what I mean https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Phonos/+/858423

https://gerrit.wikimedia.org/r/c/mediawiki/vendor/+/831998 is now ready for re-review.

Also:

• Should it strip newlines in comments? (e.g. https://test.wikipedia.org/wiki/Wikipedia:AddMe-test#Voting_13)
• If you support and your comment has a newline, if you try to vote again you are not warned about it being a duplicate (perhaps the regex does not like newlines?)

@HMonroy I clicked on 5 IPA words with 5 times each. I also added an extra partial one before it was completed and in total, it recorded 5 statsv as been in the screenshots since they group them. I also checked the Dashboard and registered all 26 of my clicks.

Change 856878 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Switch from a ButtonWidget to a PopupButtonWidget

https://gerrit.wikimedia.org/r/856878

The fonts on preview page have been smaller then normal pages since few days ago on jawiki. I was wondering if you could check it up. thanks!

@Samwilson , @dom_walden @TheresNoTime
After the change introduced here, the preview (in the vector-2022 skin) reverted to the standard font size in the main space,
but on Wikisource in the "Page" NS it made that (in the preview) unfortunately the font size is too small(!) (
(left view; right: preview):

After the last software update the preview text font size has been restored but the edit form and editnotice still have 16px font.

@Samwilson I am also finding a few other differences in how we treat Phonos after this change. I am comparing beta with my local version running Phonos 0.1.0 (580a1d3) 07:35, 7 November 2022.

@Eevans you mentioned Swift expiry in T320675#8317876. Would it be acceptable to set X-Delete-At to something like 3 months in the future, and if the file gets used a week prior to the expiration date, use describe to reset X-Delete-At for another 3 months? (Date ranges are TBD and can be adjusted as we go)

There's nothing to QA here I don't think? The patch was for production and is identical to what Sammy already cherry-picked on Beta. The real test comes when we get Phonos deployed to our first production wiki (T321084). I'm going to be bold and mark this as resolved. Thanks to all who helped with this task!

@Samwilson thank you for your help with this! I abandoned my patch. Should I assign this task to you so that it reflects that you're working on it.?

Change 854648 abandoned by HMonroy:

[mediawiki/skins/Vector@master] Set z-index for vector-body higher than mw-panel

Reason:

We are going with an overlay instead https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Phonos/+/856878/

https://gerrit.wikimedia.org/r/854648

Change 858387 merged by jenkins-bot:

[mediawiki/libs/IPAValidator@main] composer: Remove split test scripts

https://gerrit.wikimedia.org/r/858387

Change 858387 had a related patch set uploaded (by Samtar; author: Samtar):

[mediawiki/libs/IPAValidator@main] composer: Remove split test scripts

https://gerrit.wikimedia.org/r/858387

Change 854994 merged by Samtar:

[mediawiki/libs/IPAValidator@main] Tidy repo post-import

https://gerrit.wikimedia.org/r/854994