Maniphest T97639

Unexpected $1 is shown in error messages of ActivateDeactivateForm on Special:Tags
Closed, ResolvedPublic
Actions

Description

https://www.mediawiki.org/w/index.php?title=Special:Tags/activate&tag=dollar1bug : "$1The tag "dollar1bug" does not exist."

See line 374 in includes/specials/SpecialTags.php

Details

	Subject	Repo	Branch	Lines +/-
	Fix stray $1 in some Special:Tags error messages	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

liangent created this task.Apr 30 2015, 12:48 PM

liangent raised the priority of this task from to Needs Triage.

liangent updated the task description. (Show Details)

liangent added a project: MediaWiki-Change-tagging.

liangent subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2015, 12:48 PM

Liuxinyu970226 subscribed.May 12 2015, 10:46 AM

Somehow a stray $1 crept into line 395 of includes/specials/SpecialTags.php...

This is a trivial bug to fix, so would be a good "beginner" task for GCI2015. I'm happy to mentor it.

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 17 2015, 10:53 AM

Imported as https://codein.withgoogle.com/dashboard/tasks/5680455227539456/

Aklapper moved this task from Proposed to Imported into GCI site on the Google-Code-In-2015 board.Dec 5 2015, 8:43 PM

Change 257687 had a related patch set uploaded (by TTO):
Fix stray $1 in some Special:Tags error messages

https://gerrit.wikimedia.org/r/257687

gerritbot added a project: Patch-For-Review.Dec 9 2015, 12:13 PM

TTO closed this task as Resolved.Dec 9 2015, 12:15 PM

TTO assigned this task to Georggi1999.

TTO removed a project: Patch-For-Review.

TTO set Security to None.

Change 257687 merged by jenkins-bot:
Fix stray $1 in some Special:Tags error messages

https://gerrit.wikimedia.org/r/257687

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-12-15_(1.27.0-wmf.9)), MW-1.27-release-notes.Dec 9 2015, 1:00 PM

Liuxinyu970226 unsubscribed.Dec 11 2015, 10:28 AM