| Jdforrester-WMF | |
| Feb 13 2015, 8:59 PM |
| F40813: 5jx7QRq.png | |
| Feb 13 2015, 11:11 PM |
TimedMediaHandler's use of jQuery UI adds a set of additional loads to any page that has timed media on it. This is (a) ugly and (b) expensive in terms of client time/network/CPU.
Instead, let's use OOUI's styles, which are arguably not better but are at least consistent, and don't need additional loads (as right now many, and soon enough every, page load already loads this).
Note that we are also considering dropping those parts completely as part of T100106.
From IRC, selected lines:
ori: that's 300kb of javascript on barack obama for the media player http://i.imgur.com/5jx7QRq.png marktraceur: Oh no. marktraceur: Wait, jquery UI is HOW BIG? marktraceur: WHAT THE HELL ori: something's wrong, right? ori: it grew James_F: marktraceur: We could switch to something else that's more performant, maybe? marktraceur: Maybe. James_F: But switching from jQuery UI to OOjs UI might be less effort for the same general pay-off.
I think "Making TMH better" is rather more epic than justifies blocking this issue.
jQUI is ~200K minified/uncompressed, OOUI is 300K, so as long as OOUI is not included on every page this will actually increase the payload. I don't think it's very significant anyway; gzip will shrink these to 10-20%, and TMH is a video player; a typical video is probably in the megabytes and will dominate traffic costs. There might be valid reasons for replacing jQUI with OOUI, but script size is not one of them, at least for the moment.
This has partialy been done.
Transcode was switched to oo-ui.
All that needs left as far as it looks is the MwEmbedModules/ folder.
But also they are thinking off switching to videojs which is more modern.
One thing that can really still be 'easily' done is to replace the popup dialog for enlarging thumbed videos to OOjs UI. The Kaltura player is however fully build with jQuery UI, so not likely that it will be removed from there.
On a Commons page with TMH in videoJS mode, jQUI is now still loaded, because:
Not AFAICT pulled in by TMH at all, just the gadgets.
Since we're replacing the Kaltura player with Video.js (T100106), which apparently doesn't rely on jQueryUI, and we'll eventually be migrating from OOUI to Vue.js components anyway, can we close this task as Declined?
Mass-Declining all open tasks about the Kaltura audio/video player, as that code is no longer used and has been deleted. See T306971 for more information.
