In T19496#217399, @Jaredzimmerman-WMF wrote:To address the issue of "knowing if it saved" I'd recommend disabling the save button if no changes have been made since last save. I don't think this is absolute needed but it's another reminder that there is nothing you need to do.
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned In
- T112379: [Regression] Changing preferences while JS is loading will disable the save button after loading is finished
rMWb5d46d22b5e4: Disable Preferences save button before setting change - Mentioned Here
- T112379: [Regression] Changing preferences while JS is loading will disable the save button after loading is finished
T19496: Automatically hide "Your preferences have been saved." message when changing preferences
Event Timeline
Comment Actions
Change 190569 had a related patch set uploaded (by Sn1per):
Disable Preferences save button before setting change
Comment Actions
Change 190569 merged by jenkins-bot:
Disable Preferences save button before setting change
Comment Actions
I went to a foreign wiki I have never visited before and as the first step after my account was autocreated there, I went to [[Special:Preferences]] to change the UI language to something I can cope with. With the JS still loading and the page displayed as one big list instead of the tabbed interface, I changed the language; then the JS finished loading and the display switched to a nice tabbed interface… with the Save button disabled, since I modified the setting prior to the script run. So I needed to change something there and back again in order to be able to save the language setting.
Just saying.
Comment Actions
Maybe the original form data could be saved in the PHP phase and a check (similar to the "you didn't save your preferences" check) could be performed to decide whether or not to disable the save button?
Comment Actions
Created an own task to track this regression: T112379: [Regression] Changing preferences while JS is loading will disable the save button after loading is finished
Comment Actions
Reverted in https://gerrit.wikimedia.org/r/#/c/252021
We should create an alternative solution, since this approach cannot work with async loading of JS. A hint:
you'd have to compare .value to .defaultValue for all inputs on the page on load
Comment Actions
Change 255712 had a related patch set uploaded (by Sn1per):
Disable Preferences save button if settings have not changed
Comment Actions
Change 255712 merged by jenkins-bot:
Disable Preferences save button if settings have not changed